Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added integration tests #63

Closed
wants to merge 1 commit into from
Closed

Conversation

VedRatan
Copy link
Collaborator

@VedRatan VedRatan commented Feb 15, 2024

Description

This PR adds up Integration tests for si, sib controllers. Tests are written using Chainsaw

Fixes #16

Does this PR introduce a breaking change?

Checklist

  • PR title follows the <type>: <description> convention
  • I use conventional commits in my commit messages
  • I have updated the documentation accordingly
  • I Keep It Small and Simple: The smaller the PR is, the easier it is to review and have it merged
  • I have performed a self-review of my code
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Additional information for reviewer

Mention if this PR is part of any design or a continuation of previous PRs

`test`

@anurag-rajawat anurag-rajawat self-requested a review February 16, 2024 05:09
@anurag-rajawat
Copy link
Collaborator

Put these controllers' tests in a separate tests/controllers directory.

@anurag-rajawat
Copy link
Collaborator

To enable testing within our CI pipeline, we need to provision a k8s cluster. So add jobs in our CI to provision a k8s cluster and leverage chainsaw GHA to run tests.
Additionally, add/update the make test target to use chainsaw to run tests.

tests/controllers/sib-updation/nimbus-policy.yaml Outdated Show resolved Hide resolved
tests/controllers/sib-deletion/nimbus-policy.yaml Outdated Show resolved Hide resolved
tests/controllers/sib-deletion/chainsaw-test.yaml Outdated Show resolved Hide resolved
.github/workflows/conformance.yaml Outdated Show resolved Hide resolved
@VedRatan VedRatan force-pushed the integration-tests branch 3 times, most recently from 0e5f6d2 to bde2ed9 Compare February 20, 2024 09:00
@VedRatan VedRatan closed this Feb 20, 2024
@VedRatan VedRatan deleted the integration-tests branch February 20, 2024 09:37
@VedRatan VedRatan restored the integration-tests branch February 20, 2024 09:41
@VedRatan VedRatan deleted the integration-tests branch February 20, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Core]: Add integration tests
2 participants