Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(adapters): Extract common functionalites for reconcilation of native policies #52

Closed

Conversation

anurag-rajawat
Copy link
Collaborator

Description

Part 1 of #49.

Since adapters depend on nimbus this PR adds common functionalities, which will be used in the second part to reconcile adapter policies. Once this is merged then we'll update nimbus dependency in adapters.

Fixes #49

Does this PR introduce a breaking change?
No

Checklist

  • PR title follows the <type>: <description> convention
  • I use conventional commits in my commit messages
  • I have updated the documentation accordingly
  • I Keep It Small and Simple: The smaller the PR is, the easier it is to review and have it merged
  • I have performed a self-review of my code
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Additional information for reviewer

Mention if this PR is part of any design or a continuation of previous PRs

@anurag-rajawat anurag-rajawat added the enhancement New feature or request label Feb 7, 2024
@anurag-rajawat anurag-rajawat force-pushed the adapters-reconcilation-1 branch from 5f6ea02 to f2ff3dd Compare February 7, 2024 14:55
@anurag-rajawat anurag-rajawat force-pushed the adapters-reconcilation-1 branch from f2ff3dd to 98355cc Compare February 7, 2024 14:58
@anurag-rajawat anurag-rajawat deleted the adapters-reconcilation-1 branch February 7, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix core and adapters to reconcile their policies.
1 participant