Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaks some end of file exports #30

Closed
lencioni opened this issue Apr 25, 2016 · 1 comment
Closed

Breaks some end of file exports #30

lencioni opened this issue Apr 25, 2016 · 1 comment

Comments

@lencioni
Copy link

Thanks for your work on this plugin! I think I ran into an issue with this plugin when encountering code like:

const foo = 1;
const BAR = 2;

export { foo as default, BAR };

I would expect there to be a default and a BAR named export. However, it seems as though there is only a default export in this case.

Here's a failing test case I wrote:

{
  name: 'end of module export',
  code: 'const foo = 1;const BAR = 2;export { foo as default, BAR }',
  expected: {
    module: {
      default: 1,
      BAR: 2
    },
    exports: {
      default: 1,
      BAR: 2
    }
  }
},
@59naga 59naga closed this as completed in d368c3e Apr 25, 2016
59naga added a commit that referenced this issue Apr 25, 2016
- add spec "export default and named declarations (#30)"
@59naga
Copy link
Owner

59naga commented Apr 25, 2016

Even here confirmed, that is fixed. thanks @lencioni 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants