Resolve Terraform and ECS errors #5
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace with local and native templatefile function.
Not needed when using templatefile().
Missing var health_check_path added with default.
Add var assign_public_ip with default.
This should allow the grafana user to create the needed files and folders in efs.
This should allow the grafana user to create the needed files and folders in efs.
These are not needed to run grafana as is.
This should be /login.
Fix Terraform and AWS errors
This check monitors the internal health of the container on port 3000.
Add container healthcheck
Add outputs for efs attributes
Improve README
Feat/spot with fallback
Update/python3.12
Add AWS services overview to README
* Add Grafana Renderer plugin (as container) This plugin allows to render images of individual panels on any dashboard. Certain vars have been renamed to distinguish them from each other.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should fix all Terraform and ECS errors when trying to use this module. I tried to explain the changes in the commit messages as much as I could.