Supressing xcode 10.2 build warnings

52inc · Mar 31, 2019 · bda0739 · bda0739
1 parent ebb0b90
commit bda0739
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 16 deletions.
diff --git a/Library/SwiftyGiphyAPI.swift b/Library/SwiftyGiphyAPI.swift
@@ -253,7 +253,7 @@ public extension SwiftyGiphyAPI {
     ///   - rating: The max rating for the gifs
     ///   - offset: The paging offset
     ///   - completion: The completion block to call when done
-    public func getTrending(limit: Int = 25, rating: SwiftyGiphyAPIContentRating = .pg13, offset: Int? = nil, completion: GiphyMultipleGIFResponseBlock?)
+    func getTrending(limit: Int = 25, rating: SwiftyGiphyAPIContentRating = .pg13, offset: Int? = nil, completion: GiphyMultipleGIFResponseBlock?)
     {
         guard apiKey != nil || !isUsingDefaultAPIBase else {
             print("ATTENTION: You need to set your Giphy API key before using SwiftyGiphy.")
@@ -311,7 +311,7 @@ public extension SwiftyGiphyAPI {
     ///   - rating: The max rating for the gifs
     ///   - offset: The paging offset
     ///   - completion: The completion block to call when done
-    public func getSearch(searchTerm: String, limit: Int = 25, rating: SwiftyGiphyAPIContentRating = .pg13, offset: Int? = nil, completion: GiphyMultipleGIFResponseBlock?)
+    func getSearch(searchTerm: String, limit: Int = 25, rating: SwiftyGiphyAPIContentRating = .pg13, offset: Int? = nil, completion: GiphyMultipleGIFResponseBlock?)
     {
         guard apiKey != nil || !isUsingDefaultAPIBase else {
             print("ATTENTION: You need to set your Giphy API key before using SwiftyGiphy.")
@@ -369,7 +369,7 @@ public extension SwiftyGiphyAPI {
     ///   - rating: The max rating for the image (optional, defaults to pg13)
     ///   - languageCode: The language code (optional)
     ///   - completion: The completion block to call when done
-    public func getTranslation(searchTerm: String, rating: SwiftyGiphyAPIContentRating = .pg13, languageCode: String? = nil, completion: GiphySingleGIFResponseBlock?)
+    func getTranslation(searchTerm: String, rating: SwiftyGiphyAPIContentRating = .pg13, languageCode: String? = nil, completion: GiphySingleGIFResponseBlock?)
     {
         guard apiKey != nil || !isUsingDefaultAPIBase else {
             print("ATTENTION: You need to set your Giphy API key before using SwiftyGiphy.")
@@ -425,7 +425,7 @@ public extension SwiftyGiphyAPI {
     ///   - tag: The tag to limit the randomness with
     ///   - rating: The max rating to limit the image to
     ///   - completion: The completion block to call when done
-    public func getRandom(tag: String, rating: SwiftyGiphyAPIContentRating = .pg13, completion: GiphySimpleSingleGIFResponseBlock?)
+    func getRandom(tag: String, rating: SwiftyGiphyAPIContentRating = .pg13, completion: GiphySimpleSingleGIFResponseBlock?)
     {
         guard apiKey != nil || !isUsingDefaultAPIBase else {
             print("ATTENTION: You need to set your Giphy API key before using SwiftyGiphy.")
@@ -475,7 +475,7 @@ public extension SwiftyGiphyAPI {
     /// - Parameters:
     ///   - identifier: The identifier of the gif
     ///   - completion: The completion block to call when done.
-    public func getGIFById(identifier: String, completion: GiphySingleGIFResponseBlock?)
+    func getGIFById(identifier: String, completion: GiphySingleGIFResponseBlock?)
     {
         guard apiKey != nil || !isUsingDefaultAPIBase else {
             print("ATTENTION: You need to set your Giphy API key before using SwiftyGiphy.")
@@ -529,7 +529,7 @@ public extension SwiftyGiphyAPI {
     ///   - rating: The max rating for the stickers
     ///   - offset: The paging offset
     ///   - completion: The completion block to call when done
-    public func getTrendingStickers(limit: Int = 25, rating: SwiftyGiphyAPIContentRating = .pg13, offset: Int? = nil, completion: GiphyMultipleGIFResponseBlock?)
+    func getTrendingStickers(limit: Int = 25, rating: SwiftyGiphyAPIContentRating = .pg13, offset: Int? = nil, completion: GiphyMultipleGIFResponseBlock?)
     {
         guard apiKey != nil || !isUsingDefaultStickerAPIBase else {
             print("ATTENTION: You need to set your Giphy API key before using SwiftyGiphy.")
@@ -587,7 +587,7 @@ public extension SwiftyGiphyAPI {
     ///   - rating: The max rating for the stickers
     ///   - offset: The paging offset
     ///   - completion: The completion block to call when done
-    public func getSearchStickers(searchTerm: String, limit: Int = 25, rating: SwiftyGiphyAPIContentRating = .pg13, offset: Int? = nil, completion: GiphyMultipleGIFResponseBlock?)
+    func getSearchStickers(searchTerm: String, limit: Int = 25, rating: SwiftyGiphyAPIContentRating = .pg13, offset: Int? = nil, completion: GiphyMultipleGIFResponseBlock?)
     {
         guard apiKey != nil || !isUsingDefaultStickerAPIBase else {
             print("ATTENTION: You need to set your Giphy API key before using SwiftyGiphy.")
@@ -645,7 +645,7 @@ public extension SwiftyGiphyAPI {
     ///   - rating: The max rating for the image (optional, defaults to pg13)
     ///   - languageCode: The language code (optional)
     ///   - completion: The completion block to call when done
-    public func getTranslationStickers(searchTerm: String, rating: SwiftyGiphyAPIContentRating = .pg13, languageCode: String? = nil, completion: GiphySingleGIFResponseBlock?)
+    func getTranslationStickers(searchTerm: String, rating: SwiftyGiphyAPIContentRating = .pg13, languageCode: String? = nil, completion: GiphySingleGIFResponseBlock?)
     {
         guard apiKey != nil || !isUsingDefaultStickerAPIBase else {
             print("ATTENTION: You need to set your Giphy API key before using SwiftyGiphy.")
@@ -701,7 +701,7 @@ public extension SwiftyGiphyAPI {
     ///   - tag: The tag to limit the randomness with
     ///   - rating: The max rating to limit the image to
     ///   - completion: The completion block to call when done
-    public func getRandomSticker(tag: String, rating: SwiftyGiphyAPIContentRating = .pg13, completion: GiphySimpleSingleGIFResponseBlock?)
+    func getRandomSticker(tag: String, rating: SwiftyGiphyAPIContentRating = .pg13, completion: GiphySimpleSingleGIFResponseBlock?)
     {
         guard apiKey != nil || !isUsingDefaultStickerAPIBase else {
             print("ATTENTION: You need to set your Giphy API key before using SwiftyGiphy.")

diff --git a/Podfile.lock b/Podfile.lock
@@ -6,7 +6,7 @@ PODS:
   - SDWebImage/GIF (4.0.0):
     - FLAnimatedImage (~> 1.0)
     - SDWebImage/Core
-  - SwiftyGiphy (1.1.1):
+  - SwiftyGiphy (1.2.0):
     - FLAnimatedImage (~> 1.0)
     - NSTimer-Blocks
     - ObjectMapper (~> 3.0)
@@ -31,8 +31,8 @@ SPEC CHECKSUMS:
   NSTimer-Blocks: 88faf9aef5f250ead087f3f67ae642517083bf36
   ObjectMapper: b612bf8c8e99c4dc0bb6013a51f7c27966ed5da9
   SDWebImage: 76a6348bdc74eb5a55dd08a091ef298e56b55e41
-  SwiftyGiphy: bceb75259b1b3a8a1d76019a90b9009119fe823c
+  SwiftyGiphy: 6fb86ca967445826a9b1aa629ce22d970bca579d
 
 PODFILE CHECKSUM: 99ae6577f47a8d8b2d37875a1c21f2c41e5295fb
 
-COCOAPODS: 1.5.3
+COCOAPODS: 1.6.1
diff --git a/SwiftyGiphy.xcodeproj/project.pbxproj b/SwiftyGiphy.xcodeproj/project.pbxproj
@@ -122,7 +122,7 @@
 			isa = PBXProject;
 			attributes = {
 				LastSwiftUpdateCheck = 0820;
-				LastUpgradeCheck = 1000;
+				LastUpgradeCheck = 1020;
 				ORGANIZATIONNAME = 52inc;
 				TargetAttributes = {
 					C60B80391E71E45000ECF39E = {
@@ -135,7 +135,7 @@
 			};
 			buildConfigurationList = C60B80351E71E45000ECF39E /* Build configuration list for PBXProject "SwiftyGiphy" */;
 			compatibilityVersion = "Xcode 3.2";
-			developmentRegion = English;
+			developmentRegion = en;
 			hasScannedForEncodings = 0;
 			knownRegions = (
 				en,
@@ -189,7 +189,7 @@
 			files = (
 			);
 			inputPaths = (
-				"${SRCROOT}/Pods/Target Support Files/Pods-SwiftyGiphySample/Pods-SwiftyGiphySample-frameworks.sh",
+				"${PODS_ROOT}/Target Support Files/Pods-SwiftyGiphySample/Pods-SwiftyGiphySample-frameworks.sh",
 				"${BUILT_PRODUCTS_DIR}/FLAnimatedImage/FLAnimatedImage.framework",
 				"${BUILT_PRODUCTS_DIR}/NSTimer-Blocks/NSTimer_Blocks.framework",
 				"${BUILT_PRODUCTS_DIR}/ObjectMapper/ObjectMapper.framework",
@@ -206,7 +206,7 @@
 			);
 			runOnlyForDeploymentPostprocessing = 0;
 			shellPath = /bin/sh;
-			shellScript = "\"${SRCROOT}/Pods/Target Support Files/Pods-SwiftyGiphySample/Pods-SwiftyGiphySample-frameworks.sh\"\n";
+			shellScript = "\"${PODS_ROOT}/Target Support Files/Pods-SwiftyGiphySample/Pods-SwiftyGiphySample-frameworks.sh\"\n";
 			showEnvVarsInLog = 0;
 		};
 /* End PBXShellScriptBuildPhase section */
@@ -246,6 +246,7 @@
 			isa = XCBuildConfiguration;
 			buildSettings = {
 				ALWAYS_SEARCH_USER_PATHS = NO;
+				CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED = YES;
 				CLANG_ANALYZER_NONNULL = YES;
 				CLANG_CXX_LANGUAGE_STANDARD = "gnu++0x";
 				CLANG_CXX_LIBRARY = "libc++";
@@ -304,6 +305,7 @@
 			isa = XCBuildConfiguration;
 			buildSettings = {
 				ALWAYS_SEARCH_USER_PATHS = NO;
+				CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED = YES;
 				CLANG_ANALYZER_NONNULL = YES;
 				CLANG_CXX_LANGUAGE_STANDARD = "gnu++0x";
 				CLANG_CXX_LIBRARY = "libc++";