Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEAT: extend dynamically allocated evidence array by additionalCapacity #59

Merged
merged 6 commits into from
Oct 30, 2024
Merged

FEAT: extend dynamically allocated evidence array by additionalCapacity #59

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5d9a370
FEAT: extend dynamically allocated evidence array by additionalCapacity
justadreamer Oct 25, 2024
cc9536e
FEAT/REFACT: Modifed evidence so that if the capacity of the array is…
jwrosewell Oct 29, 2024
5a151ba
REFACT: Removed the additional capacity feature. There is no need for…
jwrosewell Oct 29, 2024
a83fdd4
REFACT: Modified tests and dependent classes to work with the refacte…
jwrosewell Oct 29, 2024
071b5a7
FIX: handle freeing NULL evidence
justadreamer Oct 29, 2024
54d8c7f
FIX: warning on windows
justadreamer Oct 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion EvidenceBase.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ fiftyoneDegreesEvidenceKeyValuePairArray* EvidenceBase::get() {
for (map<string, string>::const_iterator iterator = begin();
iterator != end();
iterator++) {
EvidencePrefixMap *map =
EvidencePrefixMap* map =
EvidenceMapPrefix(iterator->first.c_str());
if (map != NULL && isRelevant(map->prefixEnum)) {
EvidenceAddString(
Expand Down
28 changes: 14 additions & 14 deletions EvidenceBase.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,9 +71,9 @@ namespace FiftyoneDegrees {
* @{
*/

/**
* Construct a new instance containing no evidence.
*/
/**
* Construct a new instance containing no evidence.
*/
EvidenceBase();

/**
Expand All @@ -87,12 +87,12 @@ namespace FiftyoneDegrees {
* @{
*/

/**
* Get the underlying C structure containing the evidence. This
* only includes evidence which is relevant to the engine. Any
* evidence which is irrelevant will not be included in the result.
* @return pointer to a populated C evidence structure
*/
/**
* Get the underlying C structure containing the evidence. This
* only includes evidence which is relevant to the engine. Any
* evidence which is irrelevant will not be included in the result.
* @return pointer to a populated C evidence structure
*/
fiftyoneDegreesEvidenceKeyValuePairArray* get();

/**
Expand All @@ -101,9 +101,9 @@ namespace FiftyoneDegrees {
* @{
*/

/**
* Clear all evidence items from the instance.
*/
/**
* Clear all evidence items from the instance.
*/
void clear();

/**
Expand All @@ -118,7 +118,7 @@ namespace FiftyoneDegrees {
* @param last item to remove
*/
void erase(iterator first, iterator last);

/**
* @}
*/
Expand All @@ -133,7 +133,7 @@ namespace FiftyoneDegrees {
virtual bool isRelevant(fiftyoneDegreesEvidencePrefix prefix);
private:
/** The underlying evidence structure. */
fiftyoneDegreesEvidenceKeyValuePairArray *evidence;
fiftyoneDegreesEvidenceKeyValuePairArray* evidence;
};
}
}
Expand Down
Loading