storagezone: use d.Partial in Update instead of revertUpdateValues #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That after a failed update changes to the resource are still applied is a know bug (hashicorp/terraform-plugin-sdk#476). It affects attributes that are not retrieved via the Get function and set only by the provider. custom_404_file_path is such a field. As workaround d.Partial() can be called. This is more simple then the revertUpdateValues() implementation.
|
@jspizziri fyi |
|
@fho wow, nice find. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The behavior described in #1 (comment) made me very suspicious because I did not encounter the behaviour before and other providers also do not revert the state after a failed update.
I turned out that this is an upstream bug: hashicorp/terraform-plugin-sdk#476