Eroshare naming enhancements and XhamsterRipper method refactoring. #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le saving (as meta-data).
…single-picture-ripper
- Eroshare naming now includes username, gallery-id, and gallery name. e.g. for url=https://eroshare.com/aB12C3d uploaded by sample-user with title="hello there", the directory name will be: eroshare_sample-user_aB12C3d_hello-there The raw HTML page is also now saved for eroshare. - Refactored utility methods from XhamsterRipper into base AlbumRipper.
|
Hi @sleaze - it looks like you've got a bunch of PRs open that mostly are unrelated but include a lot of previous unrelated commits. Is it feasible to split them out into independent commits and PRs that I can test and merge one at a time? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
e.g. for url=https://eroshare.com/aB12C3d uploaded by sample-user with
title="hello there", the directory name will be:
The raw HTML page is also now saved for eroshare.