Fix missing Polarity on PinConf

4ms · Dec 6, 2024 · c8d2516 · c8d2516
1 parent 37e5782
commit c8d2516
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/src/drivers/pinconf.hh b/src/drivers/pinconf.hh
@@ -96,6 +96,8 @@ struct PinConf {
 	PinNum pin{PinNum::Unused};
 	PinAF af{PinAF::AFNone};
 
+	// FIXME: Polarity is not used
+
 	void init(PinMode mode,
 			  PinPull pull = PinPull::None,
 			  PinPolarity polarity = PinPolarity::Normal,

diff --git a/src/main.cc b/src/main.cc
@@ -47,10 +47,10 @@ void main()
 
 	// Check Boot Select pin
 	if constexpr (Board::UseBootSelect) {
-		Board::BootSelectPin.init(PinMode::Input, PinPull::Up, PinPolarity::Inverted);
+		Board::BootSelectPin.init(PinMode::Input, PinPull::Up);
 		// delay to allow pull-up to settle
 		udelay(1000);
-		if (Board::BootSelectPin.read()) {
+		if (!Board::BootSelectPin.read()) {
 			image_type = BootLoader::LoadTarget::SSBL;
 			print("Boot Select pin detected active: Loading alt image...\n");
 		}