Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update wifi patch list when patch storage changed #300

Merged
merged 2 commits into from
Jul 19, 2024

Conversation

LnnrtS
Copy link
Collaborator

@LnnrtS LnnrtS commented Jul 11, 2024

This try to catch changes in the patch storage and notifies all connected wifi clients of the updated patch list.

It works for me when creating a new patch via the GUI. Couldn't test inserting an SD card due to #299 and I still need to get hold of an USB-C thumb drive to test that

@danngreen
Copy link
Member

I tested this branch out. I get the "Not connected" notice at the top of the browser when I insert an SD Card containing a lot of files, but it goes back to "Connected" by itself.
Inserting and removing a card or thumb drive doesn't cause the browser to refresh the patch list. It doesn't populate the SD or USB lists at all no matter what I do.

Then I applied the SDMMC timeout fix to the branch. Now the SD Card is updated almost immediately in the browser, with no "No Connection".

USB insert/eject still does not cause any changes in the browser...

@LnnrtS LnnrtS force-pushed the wifi_notify_media_change branch from 00f3236 to b55eeb1 Compare July 16, 2024 07:31
@LnnrtS
Copy link
Collaborator Author

LnnrtS commented Jul 18, 2024

USB insert/eject still does not cause any changes in the browser...

hm, this is working for me. Same as with sd card

@LnnrtS LnnrtS marked this pull request as ready for review July 18, 2024 10:55
@danngreen
Copy link
Member

USB insert/eject still does not cause any changes in the browser...

hm, this is working for me. Same as with sd card

OK, yeah it's working for me now, too. I don't know what changed.
But I tested it out, and seems to be working well now. I noticed the port changed from :8080 to :80, that's nice.

I'll go ahead and merge this into wifi_query_ip since there's no application.bin conflict

@danngreen danngreen merged commit ea1886a into wifi_query_ip Jul 19, 2024
@danngreen danngreen deleted the wifi_notify_media_change branch July 19, 2024 22:18
@LnnrtS LnnrtS mentioned this pull request Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants