-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wifi support larger patch files #283
Conversation
@danngreen not ready to merge but ready for comment |
Looks good. 8MB is plenty, we can play with that.
"Less aggressive" means checking for connection less often? |
I changed the heartbeat to be sent automatically by the metamodule (instead of as a response from the browser) and increased the timeout after which it would show disconnected. Now I can easily update files up to ~100kB but something on the metamodule side chokes on them at least in the MB range. Since the serial is at 115200 at the moment, transferring such large files already takes way over one minute. Should we set a hard limit for patch files which is then is enforced already at the frontend? Or should we first try to push the limit further (which will probably require increasing the link speed)? |
If increasing the speed doesn't work (or is unstable with the longer cables), then setting a hard limit on the front end to 100k or something lower to be safe is an OK fallback. I would anticipate that large patches would be rare since you can only make a patch file that big if you have lots of modules with saved state. As transfer time becomes larger, using a physical medium becomes more convenient anyways. |
This is ready to be tested. There is no limit on the upload size yet. Uploading (too) large files will time out because writing to the destination medium on the metamodule can take quite a while and that is not part of estimating the timeout on the frontend yet. I would suggest to leave it like this for now so we can merge all those open changes first and then later see if this actually becomes a problem. I wouldn't merge all of those wifi branches into main though but combine them all in a separate branch first, consolidate/combine image updates and the merge that into main. |
Ok, I'll attempt the merge of all wifi branches on a test branch and try it out. But which wifi |
Yeah I need to provide an image that has it all. So its better when I merge the those
|
Closed in favor of #309 |
This removes wifi bridge RAM as the major file size limitation for patch files.
Requests are now streamed from the browser to the metamodule. The other direction is still processing messages as a whole. This can be changed later if required.
On the metamodule side we need a large receive buffer that effectively limits the patch file size for uploading. I defined a new global region for that. This can easily be changed if there is a better way.
Now further problems appear:
Haven't tested the wifi uploading yet. Better to test this once that is resolved.