Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix bug that lead to corupted state when saving calculation plan to excel file #995

Merged
merged 1 commit into from
Jul 13, 2023

Conversation

Czaki
Copy link
Collaborator

@Czaki Czaki commented Jul 13, 2023

No description provided.

@Czaki Czaki added this to the 0.15.1 milestone Jul 13, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jul 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@deprecated-napari-hub-preview-bot

Preview page for your plugin is ready here:
https://preview.napari-hub.org/4DNucleome/PartSeg/995
Created: 2023-07-13T20:00:20.770058

@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01 🎉

Comparison is base (152a026) 92.01% compared to head (45dde19) 92.03%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #995      +/-   ##
===========================================
+ Coverage    92.01%   92.03%   +0.01%     
===========================================
  Files          203      203              
  Lines        31482    31532      +50     
===========================================
+ Hits         28969    29020      +51     
+ Misses        2513     2512       -1     
Impacted Files Coverage Δ
...SegCore/analysis/batch_processing/batch_backend.py 90.35% <100.00%> (+0.26%) ⬆️
package/PartSegCore/io_utils.py 90.20% <100.00%> (+0.13%) ⬆️
...kage/tests/test_PartSegCore/test_analysis_batch.py 99.21% <100.00%> (+0.07%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Czaki Czaki merged commit 6945822 into develop Jul 13, 2023
41 of 43 checks passed
@Czaki Czaki deleted the bugfix/fix_saving_workflow branch July 13, 2023 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant