-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add distance based watersheed to flow methods #915
Conversation
Sourcery Code Quality Report✅ Merging this PR will increase code quality in the affected files by 0.12%.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Help us improve this quality report! |
Preview page for your plugin is ready here: |
Pull Request #915 refactored by [Sourcery](https://sourcery.ai/github/). If you're happy with these changes, merge this Pull Request using the *Squash and merge* strategy. **NOTE**: As code is pushed to the original Pull Request, Sourcery will re-run and update (force-push) this Pull Request with new refactorings as necessary. If Sourcery finds no refactorings at any point, this Pull Request will be closed automatically. See our documentation [here](https://docs.sourcery.ai/GitHub/Using-Sourcery-for-GitHub/). <details> <summary>Run Sourcery locally</summary> <p> Reduce the feedback loop during development by using the Sourcery editor plugin: </p> <ul> <li><a href="https://sourcery.ai/download/?editor=vscode">VS Code</a></li> <li><a href="https://sourcery.ai/download/?editor=pycharm">PyCharm</a></li> </ul> </details> <details> <summary>Review changes via command line</summary> <p>To manually merge these changes, make sure you're on the <code>features/add_new_thresholds</code> branch, then run:</p> <pre> git fetch origin sourcery/features/add_new_thresholds git merge --ff-only FETCH_HEAD git reset HEAD^ </pre> </details> Help us [improve](https://research.typeform.com/to/j06Spdfr?type=pr_refactor&github_login=Czaki&base_repo=https%3A%2F%2Fgithub.com%2F4DNucleome%2FPartSeg.git&base_remote_ref=refs%2Fpull%2F915%2Fhead&base_ref=features%2Fadd_new_thresholds&base_sha=c507054d2295af0cbbbd823309b7e3506807dc94&head_repo=https%3A%2F%2Fgithub.com%2F4DNucleome%2FPartSeg.git&head_ref=sourcery%2Ffeatures%2Fadd_new_thresholds&base_pr_number=915&base_pr_state=open) this pull request! Co-authored-by: Sourcery AI <>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #915 +/- ##
===========================================
+ Coverage 91.76% 91.84% +0.07%
===========================================
Files 199 200 +1
Lines 30947 31071 +124
===========================================
+ Hits 28399 28536 +137
+ Misses 2548 2535 -13
☔ View full report in Codecov by Sentry. |
93d18b2
to
a6c9375
Compare
Pull Request #915 refactored by [Sourcery](https://sourcery.ai/github/). If you're happy with these changes, merge this Pull Request using the *Squash and merge* strategy. **NOTE**: As code is pushed to the original Pull Request, Sourcery will re-run and update (force-push) this Pull Request with new refactorings as necessary. If Sourcery finds no refactorings at any point, this Pull Request will be closed automatically. See our documentation [here](https://docs.sourcery.ai/GitHub/Using-Sourcery-for-GitHub/). <details> <summary>Run Sourcery locally</summary> <p> Reduce the feedback loop during development by using the Sourcery editor plugin: </p> <ul> <li><a href="https://sourcery.ai/download/?editor=vscode">VS Code</a></li> <li><a href="https://sourcery.ai/download/?editor=pycharm">PyCharm</a></li> </ul> </details> <details> <summary>Review changes via command line</summary> <p>To manually merge these changes, make sure you're on the <code>features/add_new_thresholds</code> branch, then run:</p> <pre> git fetch origin sourcery/features/add_new_thresholds git merge --ff-only FETCH_HEAD git reset HEAD^ </pre> </details> Help us [improve](https://research.typeform.com/to/j06Spdfr?type=pr_refactor&github_login=Czaki&base_repo=https%3A%2F%2Fgithub.com%2F4DNucleome%2FPartSeg.git&base_remote_ref=refs%2Fpull%2F915%2Fhead&base_ref=features%2Fadd_new_thresholds&base_sha=c507054d2295af0cbbbd823309b7e3506807dc94&head_repo=https%3A%2F%2Fgithub.com%2F4DNucleome%2FPartSeg.git&head_ref=sourcery%2Ffeatures%2Fadd_new_thresholds&base_pr_number=915&base_pr_state=open) this pull request! Co-authored-by: Sourcery AI <>
fix PARTSEG-R2
fix PARTSEG-R5
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Add option to adjust frame thick for components loaded from mask project.
Multiple minor fixes.