Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix problem with timeout for python 311 tests #869

Merged
merged 30 commits into from
Aug 1, 2023
Merged

Conversation

Czaki
Copy link
Collaborator

@Czaki Czaki commented Dec 30, 2022

No description provided.

@deprecated-napari-hub-preview-bot
Copy link

deprecated-napari-hub-preview-bot bot commented Dec 30, 2022

Preview page for your plugin is ready here:
https://preview.napari-hub.org/4DNucleome/PartSeg/869
Updated: 2023-08-01T12:34:22.115631

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Dec 30, 2022

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.03%.

Quality metrics Before After Change
Complexity 7.72 ⭐ 7.70 ⭐ -0.02 👍
Method Length 79.62 🙂 79.81 🙂 0.19 👎
Working memory 9.33 🙂 9.32 🙂 -0.01 👍
Quality 62.74% 🙂 62.77% 🙂 0.03% 👍
Other metrics Before After Change
Lines 815 817 2
Changed files Quality Before Quality After Quality Change
package/PartSegCore/analysis/batch_processing/batch_backend.py 62.74% 🙂 62.77% 🙂 0.03% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
package/PartSegCore/analysis/batch_processing/batch_backend.py FileData.add_data_part 26 😞 301 ⛔ 21 ⛔ 18.56% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
package/PartSegCore/analysis/batch_processing/batch_backend.py CalculationProcess.do_calculation 25 😞 321 ⛔ 13 😞 26.21% 😞 Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
package/PartSegCore/analysis/batch_processing/batch_backend.py CalculationManager.get_results 14 🙂 174 😞 16 ⛔ 38.34% 😞 Try splitting into smaller methods. Extract out complex expressions
package/PartSegCore/analysis/batch_processing/batch_backend.py FileData.wrote_data_to_file 17 🙂 155 😞 12 😞 43.10% 😞 Try splitting into smaller methods. Extract out complex expressions
package/PartSegCore/analysis/batch_processing/batch_backend.py FileData.write_to_excel 9 🙂 164 😞 11 😞 50.82% 🙂 Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@codecov
Copy link

codecov bot commented Dec 30, 2022

Codecov Report

Patch coverage: 95.65% and project coverage change: +0.04% 🎉

Comparison is base (1fb01af) 92.03% compared to head (3a4d8c9) 92.08%.
Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #869      +/-   ##
===========================================
+ Coverage    92.03%   92.08%   +0.04%     
===========================================
  Files          203      203              
  Lines        31530    31582      +52     
===========================================
+ Hits         29020    29082      +62     
+ Misses        2510     2500      -10     
Files Changed Coverage Δ
package/tests/test_PartSeg/test_sentry.py 97.81% <78.57%> (-2.19%) ⬇️
package/PartSeg/common_backend/base_argparser.py 98.63% <100.00%> (+0.05%) ⬆️
...SegCore/analysis/batch_processing/batch_backend.py 90.39% <100.00%> (+0.03%) ⬆️
...kage/PartSegCore/napari_plugins/save_tiff_layer.py 97.22% <100.00%> (+49.07%) ⬆️
...kage/tests/test_PartSegCore/test_napari_plugins.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Czaki Czaki changed the title fix: Fix proble with timeout for python 311 tests fix: Fix problem with timeout for python 311 tests Jan 1, 2023
@Czaki Czaki added this to the 0.15 milestone Jan 11, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jan 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Apr 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Czaki and others added 4 commits July 31, 2023 15:47
This PR is automatically created and updated by PartSeg GitHub
action cron to keep bundle dependencies modules up to date.

The updated packages are:

 * pyside6
 * rich

Co-authored-by: Czaki <[email protected]>
@Czaki Czaki modified the milestones: 0.15, 0.15.1 Jul 31, 2023
@sonarcloud
Copy link

sonarcloud bot commented Aug 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Czaki Czaki merged commit d77717b into develop Aug 1, 2023
44 checks passed
@Czaki Czaki deleted the fix/python311_test branch August 1, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant