Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add napari image custom representation for better error report via sentry #861

Merged
merged 8 commits into from
Apr 2, 2023

Conversation

Czaki
Copy link
Collaborator

@Czaki Czaki commented Dec 27, 2022

feat: Add napari image custom representation for better error report via sentry

@Czaki Czaki added this to the 0.15.0 milestone Dec 27, 2022
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Dec 27, 2022

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.22%.

Quality metrics Before After Change
Complexity 0.60 ⭐ 0.61 ⭐ 0.01 👎
Method Length 92.56 🙂 90.85 🙂 -1.71 👍
Working memory 4.38 ⭐ 4.38 ⭐ 0.00
Quality 73.36% 🙂 73.58% 🙂 0.22% 👍
Other metrics Before After Change
Lines 806 823 17
Changed files Quality Before Quality After Quality Change
package/PartSeg/common_backend/base_argparser.py 72.52% 🙂 74.09% 🙂 1.57% 👍
package/tests/test_PartSeg/test_common_backend.py 73.44% 🙂 73.52% 🙂 0.08% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
package/tests/test_PartSeg/test_common_backend.py TestBaseSettings.test_base_settings_history 0 ⭐ 306 ⛔ 10 😞 53.02% 🙂 Try splitting into smaller methods. Extract out complex expressions
package/tests/test_PartSeg/test_common_backend.py TestExceptHook.test_my_excepthook 0 ⭐ 312 ⛔ 54.65% 🙂 Try splitting into smaller methods
package/tests/test_PartSeg/test_common_backend.py TestBaseSettings.test_image_settings 0 ⭐ 300 ⛔ 9 🙂 55.27% 🙂 Try splitting into smaller methods
package/tests/test_PartSeg/test_common_backend.py TestExceptHook.test_show_error 3 ⭐ 206 ⛔ 57.86% 🙂 Try splitting into smaller methods
package/tests/test_PartSeg/test_common_backend.py TestLoadBackup.test_older_exist 3 ⭐ 182 😞 60.70% 🙂 Try splitting into smaller methods

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@deprecated-napari-hub-preview-bot
Copy link

deprecated-napari-hub-preview-bot bot commented Dec 27, 2022

Preview page for your plugin is ready here:
https://preview.napari-hub.org/4DNucleome/PartSeg/861
Updated: 2023-04-02T21:57:45.121902

@codecov
Copy link

codecov bot commented Dec 27, 2022

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (2017dd5) 91.34% compared to head (85b8bbc) 91.34%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #861   +/-   ##
========================================
  Coverage    91.34%   91.34%           
========================================
  Files          198      198           
  Lines        30505    30515   +10     
========================================
+ Hits         27864    27874   +10     
  Misses        2641     2641           
Impacted Files Coverage Δ
package/PartSeg/common_backend/base_argparser.py 98.57% <100.00%> (+0.15%) ⬆️
package/tests/test_PartSeg/test_common_backend.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sonarcloud
Copy link

sonarcloud bot commented Jan 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Feb 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Apr 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Czaki Czaki merged commit 9881c84 into develop Apr 2, 2023
@Czaki Czaki deleted the reafctor/better_error_report branch April 2, 2023 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant