Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix MSO step_limit description in GUI #843

Merged
merged 1 commit into from
Dec 14, 2022
Merged

Conversation

Czaki
Copy link
Collaborator

@Czaki Czaki commented Dec 14, 2022

No description provided.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Dec 14, 2022

Sourcery Code Quality Report

Merging this PR leaves code quality unchanged.

Quality metrics Before After Change
Complexity 2.49 ⭐ 2.49 ⭐ 0.00
Method Length 53.30 ⭐ 53.30 ⭐ 0.00
Working memory 8.95 🙂 8.95 🙂 0.00
Quality 72.61% 🙂 72.61% 🙂 0.00%
Other metrics Before After Change
Lines 287 287 0
Changed files Quality Before Quality After Quality Change
package/PartSegCore/segmentation/watershed.py 72.61% 🙂 72.61% 🙂 0.00%

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
package/PartSegCore/segmentation/watershed.py MSOWatershed.sprawl 6 ⭐ 191 😞 14 😞 46.56% 😞 Try splitting into smaller methods. Extract out complex expressions
package/PartSegCore/segmentation/watershed.py PathWatershed.sprawl 1 ⭐ 77 🙂 13 😞 66.10% 🙂 Extract out complex expressions
package/PartSegCore/segmentation/watershed.py FDTWatershed.sprawl 0 ⭐ 65 🙂 13 😞 68.92% 🙂 Extract out complex expressions
package/PartSegCore/segmentation/watershed.py PathDistanceWatershed.sprawl 0 ⭐ 60 ⭐ 13 😞 69.70% 🙂 Extract out complex expressions
package/PartSegCore/segmentation/watershed.py DistanceWatershed.sprawl 0 ⭐ 47 ⭐ 13 😞 71.77% 🙂 Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@deprecated-napari-hub-preview-bot

Preview page for your plugin is ready here:
https://preview.napari-hub.org/4DNucleome/PartSeg/843
Created: 2022-12-14T14:48:22.167890

@codecov
Copy link

codecov bot commented Dec 14, 2022

Codecov Report

Base: 89.92% // Head: 89.92% // No change to project coverage 👍

Coverage data is based on head (abadfc4) compared to base (9249e0e).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #843   +/-   ##
========================================
  Coverage    89.92%   89.92%           
========================================
  Files          194      194           
  Lines        30115    30115           
========================================
  Hits         27080    27080           
  Misses        3035     3035           
Impacted Files Coverage Δ
package/PartSegCore/segmentation/watershed.py 89.51% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Czaki Czaki merged commit 2f8a2f9 into develop Dec 14, 2022
@Czaki Czaki deleted the fix_filed_desc_mso branch December 14, 2022 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant