Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Print all exceptions instead of the latest one in exception dialog #799

Merged
merged 2 commits into from
Nov 17, 2022

Conversation

Czaki
Copy link
Collaborator

@Czaki Czaki commented Nov 17, 2022

No description provided.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Nov 17, 2022

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.28%.

Quality metrics Before After Change
Complexity 1.25 ⭐ 1.28 ⭐ 0.03 👎
Method Length 89.38 🙂 88.59 🙂 -0.79 👍
Working memory 6.02 ⭐ 6.00 ⭐ -0.02 👍
Quality 72.81% 🙂 73.09% 🙂 0.28% 👍
Other metrics Before After Change
Lines 1763 1803 40
Changed files Quality Before Quality After Quality Change
package/PartSeg/common_gui/error_report.py 51.29% 🙂 52.56% 🙂 1.27% 👍
package/tests/test_PartSeg/test_common_gui.py 75.97% ⭐ 76.21% ⭐ 0.24% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
package/PartSeg/common_gui/error_report.py ErrorDialog.__init__ 6 ⭐ 433 ⛔ 14 😞 38.14% 😞 Try splitting into smaller methods. Extract out complex expressions
package/PartSeg/common_gui/error_report.py ErrorDialog.send_information 11 🙂 260 ⛔ 10 😞 44.17% 😞 Try splitting into smaller methods. Extract out complex expressions
package/PartSeg/common_gui/error_report.py DataImportErrorDialog.__init__ 15 🙂 306 ⛔ 7 🙂 45.57% 😞 Try splitting into smaller methods
package/tests/test_PartSeg/test_common_gui.py TestMultipleFileWidget.test_load_files 1 ⭐ 272 ⛔ 12 😞 49.63% 😞 Try splitting into smaller methods. Extract out complex expressions
package/tests/test_PartSeg/test_common_gui.py test_p_load_dialog 1 ⭐ 335 ⛔ 9 🙂 53.28% 🙂 Try splitting into smaller methods

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@deprecated-napari-hub-preview-bot
Copy link

deprecated-napari-hub-preview-bot bot commented Nov 17, 2022

Preview page for your plugin is ready here:
https://preview.napari-hub.org/4DNucleome/PartSeg/799
Updated: 2022-11-17T22:07:45.484180

@Czaki Czaki added this to the 0.15.0 milestone Nov 17, 2022
@codecov
Copy link

codecov bot commented Nov 17, 2022

Codecov Report

Base: 89.82% // Head: 89.82% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (c52f7b5) compared to base (523884a).
Patch coverage: 97.22% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #799      +/-   ##
===========================================
- Coverage    89.82%   89.82%   -0.01%     
===========================================
  Files          195      194       -1     
  Lines        30039    29914     -125     
===========================================
- Hits         26984    26870     -114     
+ Misses        3055     3044      -11     
Impacted Files Coverage Δ
package/PartSeg/common_gui/error_report.py 76.32% <90.00%> (+0.57%) ⬆️
package/tests/test_PartSeg/test_common_gui.py 99.84% <100.00%> (+<0.01%) ⬆️
package/tests/conftest.py

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Czaki Czaki changed the title Print all exceptions instead of latest one in exception dialog fix: Print all exceptions instead of the latest one in exception dialog Nov 17, 2022
@Czaki Czaki merged commit d2ace1b into develop Nov 17, 2022
@Czaki Czaki deleted the bugfix/print_full_stacktrace branch November 17, 2022 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant