Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Clean warnings about threshold methods #783

Merged
merged 1 commit into from
Nov 6, 2022
Merged

Conversation

Czaki
Copy link
Collaborator

@Czaki Czaki commented Nov 6, 2022

No description provided.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Nov 6, 2022

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.17%.

Quality metrics Before After Change
Complexity 3.65 ⭐ 3.65 ⭐ 0.00
Method Length 130.33 😞 131.67 😞 1.34 👎
Working memory 7.26 🙂 7.26 🙂 0.00
Quality 67.37% 🙂 67.20% 🙂 -0.17% 👎
Other metrics Before After Change
Lines 50 50 0
Changed files Quality Before Quality After Quality Change
package/tests/test_PartSegCore/segmentation/test_threshold.py 67.37% 🙂 67.20% 🙂 -0.17% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
package/tests/test_PartSegCore/segmentation/test_threshold.py test_threshold 6 ⭐ 138 😞 7 🙂 64.92% 🙂 Try splitting into smaller methods
package/tests/test_PartSegCore/segmentation/test_threshold.py test_double_threshold 1 ⭐ 125 😞 7 🙂 71.38% 🙂 Try splitting into smaller methods

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@deprecated-napari-hub-preview-bot

Preview page for your plugin is ready here:
https://preview.napari-hub.org/4DNucleome/PartSeg/783
Created: 2022-11-06T20:11:42.591562

@codecov
Copy link

codecov bot commented Nov 6, 2022

Codecov Report

Base: 89.72% // Head: 89.72% // No change to project coverage 👍

Coverage data is based on head (548009e) compared to base (4b836c1).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #783   +/-   ##
========================================
  Coverage    89.72%   89.72%           
========================================
  Files          192      192           
  Lines        29767    29767           
========================================
  Hits         26708    26708           
  Misses        3059     3059           
Impacted Files Coverage Δ
...ts/test_PartSegCore/segmentation/test_threshold.py 91.89% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Czaki Czaki merged commit 3906d27 into develop Nov 6, 2022
@Czaki Czaki deleted the clean_warnings branch November 6, 2022 23:07
@Czaki Czaki added this to the v0.14.5 milestone Nov 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant