Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix bug in cut with roi to do not make black artifacts #767

Merged
merged 5 commits into from
Oct 21, 2022

Conversation

Czaki
Copy link
Collaborator

@Czaki Czaki commented Oct 21, 2022

No description provided.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Oct 21, 2022

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.23%.

Quality metrics Before After Change
Complexity 2.92 ⭐ 2.88 ⭐ -0.04 👍
Method Length 73.36 🙂 74.50 🙂 1.14 👎
Working memory 6.76 🙂 6.79 🙂 0.03 👎
Quality 73.46% 🙂 73.23% 🙂 -0.23% 👎
Other metrics Before After Change
Lines 1149 1166 17
Changed files Quality Before Quality After Quality Change
package/PartSegImage/image.py 70.57% 🙂 70.47% 🙂 -0.10% 👎
package/tests/test_PartSegImage/test_image.py 76.86% ⭐ 76.31% ⭐ -0.55% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
package/PartSegImage/image.py Image.__init__ 15 🙂 324 ⛔ 20 ⛔ 26.16% 😞 Try splitting into smaller methods. Extract out complex expressions
package/PartSegImage/image.py Image.get_data_by_axis 16 🙂 218 ⛔ 9 🙂 44.32% 😞 Try splitting into smaller methods
package/tests/test_PartSegImage/test_image.py TestImageBase.test_cut_image 0 ⭐ 308 ⛔ 9 🙂 55.01% 🙂 Try splitting into smaller methods
package/PartSegImage/image.py Image.cut_image 8 ⭐ 123 😞 11 😞 56.26% 🙂 Try splitting into smaller methods. Extract out complex expressions
package/PartSegImage/image.py Image._split_data_on_channels 7 ⭐ 165 😞 9 🙂 56.57% 🙂 Try splitting into smaller methods

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@deprecated-napari-hub-preview-bot
Copy link

deprecated-napari-hub-preview-bot bot commented Oct 21, 2022

Preview page for your plugin is ready here:
https://preview.napari-hub.org/4DNucleome/PartSeg/767
Updated: 2022-10-21T20:12:58.287881

@codecov
Copy link

codecov bot commented Oct 21, 2022

Codecov Report

Base: 89.29% // Head: 89.29% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (c6e6f1c) compared to base (53ec234).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head c6e6f1c differs from pull request most recent head b0595a7. Consider uploading reports for the commit b0595a7 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #767      +/-   ##
===========================================
- Coverage    89.29%   89.29%   -0.01%     
===========================================
  Files          191      190       -1     
  Lines        29598    29482     -116     
===========================================
- Hits         26429    26325     -104     
+ Misses        3169     3157      -12     
Impacted Files Coverage Δ
package/PartSegImage/image.py 90.90% <100.00%> (ø)
package/tests/test_PartSegImage/test_image.py 100.00% <100.00%> (ø)
package/tests/conftest.py

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Czaki Czaki added this to the v0.14.4 milestone Oct 21, 2022
@Czaki Czaki merged commit 9986dc4 into develop Oct 21, 2022
@Czaki Czaki deleted the bugfix/roi_black_elements branch October 21, 2022 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant