Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix saving pipeline from GUI #756

Merged
merged 4 commits into from
Oct 16, 2022
Merged

fix: Fix saving pipeline from GUI #756

merged 4 commits into from
Oct 16, 2022

Conversation

Czaki
Copy link
Collaborator

@Czaki Czaki commented Oct 16, 2022

No description provided.

@Czaki Czaki added this to the v0.14.4 milestone Oct 16, 2022
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Oct 16, 2022

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 1.69%.

Quality metrics Before After Change
Complexity 2.54 ⭐ 2.25 ⭐ -0.29 👍
Method Length 78.86 🙂 78.18 🙂 -0.68 👍
Working memory 8.12 🙂 7.91 🙂 -0.21 👍
Quality 66.21% 🙂 67.90% 🙂 1.69% 👍
Other metrics Before After Change
Lines 842 958 116
Changed files Quality Before Quality After Quality Change
package/PartSeg/_roi_analysis/main_window.py 61.20% 🙂 61.18% 🙂 -0.02% 👎
package/tests/test_PartSeg/conftest.py 86.90% ⭐ 86.56% ⭐ -0.34% 👎
package/tests/test_PartSeg/test_main_windows.py 70.60% 🙂 75.92% ⭐ 5.32% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
package/PartSeg/_roi_analysis/main_window.py Options.__init__ 0 ⭐ 593 ⛔ 17 ⛔ 39.94% 😞 Try splitting into smaller methods. Extract out complex expressions
package/PartSeg/_roi_analysis/main_window.py MainWindow.__init__ 2 ⭐ 851 ⛔ 14 😞 41.14% 😞 Try splitting into smaller methods. Extract out complex expressions
package/PartSeg/_roi_analysis/main_window.py Options.save_pipeline 11 🙂 229 ⛔ 11 😞 43.93% 😞 Try splitting into smaller methods. Extract out complex expressions
package/PartSeg/_roi_analysis/main_window.py MainMenu.load_data 8 ⭐ 162 😞 56.17% 🙂 Try splitting into smaller methods
package/tests/test_PartSeg/test_main_windows.py TestLauncherMainWindow.test_open_analysis 4 ⭐ 134 😞 12 😞 57.08% 🙂 Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@deprecated-napari-hub-preview-bot
Copy link

deprecated-napari-hub-preview-bot bot commented Oct 16, 2022

Preview page for your plugin is ready here:
https://preview.napari-hub.org/4DNucleome/PartSeg/756
Updated: 2022-10-16T16:43:01.833130

@codecov
Copy link

codecov bot commented Oct 16, 2022

Codecov Report

Base: 88.67% // Head: 88.91% // Increases project coverage by +0.24% 🎉

Coverage data is based on head (10459d9) compared to base (a40de4e).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #756      +/-   ##
===========================================
+ Coverage    88.67%   88.91%   +0.24%     
===========================================
  Files          190      190              
  Lines        29456    29557     +101     
===========================================
+ Hits         26119    26280     +161     
+ Misses        3337     3277      -60     
Impacted Files Coverage Δ
package/PartSeg/_roi_analysis/main_window.py 70.60% <100.00%> (+11.59%) ⬆️
package/tests/test_PartSeg/conftest.py 91.09% <100.00%> (+0.94%) ⬆️
package/tests/test_PartSeg/test_main_windows.py 100.00% <100.00%> (ø)
package/PartSegCore/analysis/analysis_utils.py 100.00% <0.00%> (+8.33%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Czaki Czaki merged commit 23f8ce4 into develop Oct 16, 2022
@Czaki Czaki deleted the bugfix/create_pipeline branch October 16, 2022 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant