Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improve error reporting when fail to deserialize data #574

Merged
merged 16 commits into from
Apr 13, 2022

Conversation

Czaki
Copy link
Collaborator

@Czaki Czaki commented Apr 9, 2022

…il to import data

@Czaki Czaki added this to the 0.14.0 milestone Apr 9, 2022
@deprecated-napari-hub-preview-bot

Preview page for your plugin is ready here:
https://preview.napari-hub.org/4DNucleome/PartSeg/574

@Czaki Czaki force-pushed the bugfix.better_error_reporting branch from 40bc0e0 to eedfb10 Compare April 11, 2022 09:27
@deprecated-napari-hub-preview-bot

Preview page for your plugin is ready here:
https://preview.napari-hub.org/4DNucleome/PartSeg/574

@codecov
Copy link

codecov bot commented Apr 11, 2022

Codecov Report

Merging #574 (c6b1574) into develop (607e4d2) will increase coverage by 0.08%.
The diff coverage is 79.22%.

@@             Coverage Diff             @@
##           develop     #574      +/-   ##
===========================================
+ Coverage    77.64%   77.72%   +0.08%     
===========================================
  Files          142      143       +1     
  Lines        18991    19150     +159     
===========================================
+ Hits         14745    14885     +140     
- Misses        4246     4265      +19     
Impacted Files Coverage Δ
package/PartSeg/_roi_analysis/batch_window.py 42.00% <0.00%> (ø)
...Core/analysis/batch_processing/parallel_backend.py 89.40% <0.00%> (-0.60%) ⬇️
package/PartSegCore/_old_json_hooks.py 57.14% <11.11%> (-4.32%) ⬇️
package/PartSeg/_roi_analysis/advanced_window.py 52.79% <25.00%> (-0.01%) ⬇️
package/PartSeg/common_backend/base_settings.py 95.41% <33.33%> (-0.42%) ⬇️
package/PartSegCore/json_hooks.py 92.00% <50.00%> (-8.00%) ⬇️
.../PartSeg/common_backend/python_syntax_highlight.py 77.94% <77.94%> (ø)
package/PartSegCore/io_utils.py 86.20% <96.00%> (+1.82%) ⬆️
package/PartSeg/common_gui/error_report.py 72.25% <98.33%> (+13.63%) ⬆️
...ckage/PartSeg/common_gui/algorithms_description.py 80.59% <100.00%> (+0.83%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 607e4d2...c6b1574. Read the comment docs.

@Czaki Czaki changed the title feature: Improeve error reporting when fail to deserialize data feature: Improve error reporting when fail to deserialize data Apr 11, 2022
@deprecated-napari-hub-preview-bot

Preview page for your plugin is ready here:
https://preview.napari-hub.org/4DNucleome/PartSeg/574

@deprecated-napari-hub-preview-bot

Preview page for your plugin is ready here:
https://preview.napari-hub.org/4DNucleome/PartSeg/574

@deprecated-napari-hub-preview-bot

Preview page for your plugin is ready here:
https://preview.napari-hub.org/4DNucleome/PartSeg/574

@lgtm-com
Copy link

lgtm-com bot commented Apr 12, 2022

This pull request introduces 3 alerts when merging 316ecba into 607e4d2 - view on LGTM.com

new alerts:

  • 3 for Membership test with a non-container

@deprecated-napari-hub-preview-bot

Preview page for your plugin is ready here:
https://preview.napari-hub.org/4DNucleome/PartSeg/574

@lgtm-com
Copy link

lgtm-com bot commented Apr 12, 2022

This pull request introduces 4 alerts when merging 0845e4c into 607e4d2 - view on LGTM.com

new alerts:

  • 3 for Membership test with a non-container
  • 1 for Unused local variable

@deprecated-napari-hub-preview-bot

Preview page for your plugin is ready here:
https://preview.napari-hub.org/4DNucleome/PartSeg/574

@lgtm-com
Copy link

lgtm-com bot commented Apr 12, 2022

This pull request introduces 3 alerts when merging 19037df into 607e4d2 - view on LGTM.com

new alerts:

  • 3 for Membership test with a non-container

@deprecated-napari-hub-preview-bot

Preview page for your plugin is ready here:
https://preview.napari-hub.org/4DNucleome/PartSeg/574

@lgtm-com
Copy link

lgtm-com bot commented Apr 12, 2022

This pull request introduces 4 alerts when merging 1a37bec into 607e4d2 - view on LGTM.com

new alerts:

  • 4 for Membership test with a non-container

@Czaki Czaki changed the title feature: Improve error reporting when fail to deserialize data feat: Improve error reporting when fail to deserialize data Apr 12, 2022
@deprecated-napari-hub-preview-bot

Preview page for your plugin is ready here:
https://preview.napari-hub.org/4DNucleome/PartSeg/574

@lgtm-com
Copy link

lgtm-com bot commented Apr 13, 2022

This pull request introduces 4 alerts when merging 1378424 into 607e4d2 - view on LGTM.com

new alerts:

  • 4 for Membership test with a non-container

@deprecated-napari-hub-preview-bot

Preview page for your plugin is ready here:
https://preview.napari-hub.org/4DNucleome/PartSeg/574

@lgtm-com
Copy link

lgtm-com bot commented Apr 13, 2022

This pull request introduces 4 alerts when merging 5595f06 into 607e4d2 - view on LGTM.com

new alerts:

  • 4 for Membership test with a non-container

@deprecated-napari-hub-preview-bot

Preview page for your plugin is ready here:
https://preview.napari-hub.org/4DNucleome/PartSeg/574

1 similar comment
@deprecated-napari-hub-preview-bot

Preview page for your plugin is ready here:
https://preview.napari-hub.org/4DNucleome/PartSeg/574

@lgtm-com
Copy link

lgtm-com bot commented Apr 13, 2022

This pull request introduces 4 alerts when merging e44b74c into 607e4d2 - view on LGTM.com

new alerts:

  • 4 for Membership test with a non-container

@deprecated-napari-hub-preview-bot

Preview page for your plugin is ready here:
https://preview.napari-hub.org/4DNucleome/PartSeg/574

@lgtm-com
Copy link

lgtm-com bot commented Apr 13, 2022

This pull request introduces 4 alerts when merging c6b1574 into 607e4d2 - view on LGTM.com

new alerts:

  • 4 for Membership test with a non-container

@Czaki Czaki merged commit c0db122 into develop Apr 13, 2022
@Czaki Czaki deleted the bugfix.better_error_reporting branch April 13, 2022 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant