Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add test of creating AboutDialog #539

Merged
merged 2 commits into from
Feb 18, 2022

Conversation

Czaki
Copy link
Collaborator

@Czaki Czaki commented Feb 18, 2022

No description provided.

@Czaki Czaki added this to the 0.14.0 milestone Feb 18, 2022
@deprecated-napari-hub-preview-bot

Preview page for your plugin is ready here:
https://preview.napari-hub.org/4DNucleome/PartSeg/539

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Feb 18, 2022

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.35%.

Quality metrics Before After Change
Complexity 0.51 ⭐ 0.79 ⭐ 0.28 👎
Method Length 71.36 🙂 70.85 🙂 -0.51 👍
Working memory 7.20 🙂 7.19 🙂 -0.01 👍
Quality 73.28% 🙂 72.93% 🙂 -0.35% 👎
Other metrics Before After Change
Lines 566 578 12
Changed files Quality Before Quality After Quality Change
package/PartSeg/common_gui/about_dialog.py 59.92% 🙂 53.80% 🙂 -6.12% 👎
package/tests/test_PartSeg/test_common_gui.py 74.11% 🙂 74.28% 🙂 0.17% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
package/tests/test_PartSeg/test_common_gui.py TestMultipleFileWidget.test_load_files 1 ⭐ 216.97 ⛔ 12 😞 52.58% 🙂 Try splitting into smaller methods. Extract out complex expressions
package/PartSeg/common_gui/about_dialog.py AboutDialog.__init__ 6 ⭐ 209.99 ⛔ 9 🙂 53.80% 🙂 Try splitting into smaller methods
package/tests/test_PartSeg/test_common_gui.py test_p_load_dialog 1 ⭐ 277 ⛔ 9 🙂 55.11% 🙂 Try splitting into smaller methods
package/tests/test_PartSeg/test_common_gui.py test_p_save_dialog 0 ⭐ 275 ⛔ 9 🙂 56.19% 🙂 Try splitting into smaller methods
package/tests/test_PartSeg/test_common_gui.py TestMultipleFileWidget.test_load_recent 1 ⭐ 178.98 😞 11 😞 57.22% 🙂 Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@deprecated-napari-hub-preview-bot

Preview page for your plugin is ready here:
https://preview.napari-hub.org/4DNucleome/PartSeg/539

@codecov
Copy link

codecov bot commented Feb 18, 2022

Codecov Report

Merging #539 (b2d9077) into develop (79869cf) will increase coverage by 0.14%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #539      +/-   ##
===========================================
+ Coverage    76.87%   77.01%   +0.14%     
===========================================
  Files          144      144              
  Lines        18585    18597      +12     
===========================================
+ Hits         14287    14323      +36     
+ Misses        4298     4274      -24     
Impacted Files Coverage Δ
package/PartSeg/common_gui/about_dialog.py 94.28% <100.00%> (+73.07%) ⬆️
...tSeg/plugins/napari_widgets/search_label_widget.py 92.18% <0.00%> (+0.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79869cf...b2d9077. Read the comment docs.

@Czaki Czaki merged commit b81fb09 into develop Feb 18, 2022
@Czaki Czaki deleted the bugfix/add_test_for_about_dialog branch February 18, 2022 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant