Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove defining default version of language in pre-commit configuration #1208

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

Czaki
Copy link
Collaborator

@Czaki Czaki commented Oct 14, 2024

As all tools used in pre-commit config allow defining which python version needs to be supported, there is no longer need to pin this version i pre-commit config

Summary by Sourcery

Chores:

  • Remove the default Python version specification from the pre-commit configuration.

Summary by CodeRabbit

  • Chores
    • Updated the configuration file by removing the specified default Python version.
    • Adjusted indentation for improved YAML formatting while retaining existing hooks and repositories.

@Czaki Czaki added this to the 0.16.0 milestone Oct 14, 2024
Copy link
Contributor

sourcery-ai bot commented Oct 14, 2024

Reviewer's Guide by Sourcery

This pull request removes the default Python version specification from the pre-commit configuration file. The change simplifies the configuration by relying on the individual tools to manage their Python version requirements.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Removal of default Python version specification in pre-commit config
  • Deleted the 'default_language_version' section
  • Removed the Python version pinning (python3.8)
.pre-commit-config.yaml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

coderabbitai bot commented Oct 14, 2024

Walkthrough

The changes involve modifications to the .pre-commit-config.yaml file. Specifically, the default_language_version section specifying python: python3.8 has been removed. The existing repositories and hooks remain intact, with adjustments made to the indentation for proper YAML formatting. No new hooks or repositories have been introduced, and the ci section at the end of the file remains unchanged.

Changes

File Change Summary
.pre-commit-config.yaml Removed default_language_version: python: python3.8; adjusted indentation for repos; preserved existing hooks and ci section.

Suggested labels

skip check PR title

Poem

🐇 In the garden where bunnies play,
A YAML change brightens the day.
No more Python three point eight,
Just tidy hooks that look first-rate.
Hops and skips, we celebrate! 🌼


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between ca2021b and 3bce484.

📒 Files selected for processing (1)
  • .pre-commit-config.yaml (0 hunks)
💤 Files with no reviewable changes (1)
  • .pre-commit-config.yaml

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

sonarcloud bot commented Oct 14, 2024

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Czaki - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@Czaki Czaki changed the title chore: Remove defining default version of language in pre-commit config chore: Remove defining default version of language in pre-commit configuration Oct 14, 2024
Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.14%. Comparing base (ca2021b) to head (3bce484).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1208      +/-   ##
===========================================
+ Coverage    93.13%   93.14%   +0.01%     
===========================================
  Files          210      210              
  Lines        33149    33149              
===========================================
+ Hits         30873    30878       +5     
+ Misses        2276     2271       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Czaki Czaki merged commit 0c70e06 into develop Oct 14, 2024
59 of 62 checks passed
@Czaki Czaki deleted the remnove_pytho3.8_pre-comit branch October 14, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant