-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Fix call of logger to properly pass arguments to messages #1179
Conversation
WalkthroughThese changes primarily involve improvements to the logging mechanisms across several Python files in the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
🧙 Sourcery has finished reviewing your pull request! Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (4)
- package/PartSeg/_roi_analysis/export_batch.py (1 hunks)
- package/PartSeg/common_backend/segmentation_thread.py (1 hunks)
- package/PartSeg/common_gui/advanced_tabs.py (1 hunks)
- package/PartSegCore/analysis/load_functions.py (1 hunks)
Files skipped from review due to trivial changes (3)
- package/PartSeg/_roi_analysis/export_batch.py
- package/PartSeg/common_gui/advanced_tabs.py
- package/PartSegCore/analysis/load_functions.py
Additional comments not posted (1)
package/PartSeg/common_backend/segmentation_thread.py (1)
51-53
: Enhanced logging with stack trace.The addition of
stack_info=True
in the logging statement provides valuable stack trace information, which aids in debugging by giving more context when an error occurs.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1179 +/- ##
========================================
Coverage 93.08% 93.08%
========================================
Files 209 209
Lines 32887 32887
========================================
Hits 30614 30614
Misses 2273 2273 ☔ View full report in Codecov by Sentry. |
Summary by CodeRabbit
Bug Fixes
Chores