Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: remove PyOpenGL-accelerate from dependencies because of numpy incompatibility #1155

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

Czaki
Copy link
Collaborator

@Czaki Czaki commented Jul 18, 2024

The PyOpenGL-accelerate wheels are built against NumPy 1.x that make it impossible to switch to 3D rendering.

Summary by CodeRabbit

  • Chores
    • Updated optional dependencies for accelerate and pyinstaller_base to ensure better compatibility and performance.

@Czaki Czaki added this to the 0.15.4 milestone Jul 18, 2024
Copy link
Contributor

coderabbitai bot commented Jul 18, 2024

Walkthrough

The changes in the pyproject.toml file focus on adjusting optional dependencies. The dependency management for accelerate has been simplified by directly specifying PartSeg[accelerate], eliminating a previous conditional dependency on PyOpenGL-accelerate. Additionally, PartSeg[accelerate] has been added as a dependency in the pyinstaller_base section, alongside existing dependencies PyInstaller and pydantic.

Changes

File Change Summary
pyproject.toml Modified optional dependencies for accelerate and pyinstaller_base sections.

Poem

In the code where dependencies dance,
A rabbit hopped to take a chance,
With PartSeg in the accelerate crown,
And PyInstaller to never let us down,
Dependencies now simply enhance! 🌟


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have skipped reviewing this pull request. We don't review packaging changes - Let us know if you'd like us to change this.

Copy link

sonarcloud bot commented Jul 18, 2024

@Czaki Czaki changed the title build: remove PyOpenGL-accelerate from dependecies because of numpy incompatybility build: remove PyOpenGL-accelerate from dependencies because of numpy incompatibility Jul 18, 2024
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 3937247 and f5eb4a5.

Files selected for processing (1)
  • pyproject.toml (2 hunks)
Additional comments not posted (1)
pyproject.toml (1)

117-117: LGTM!

The addition of PartSeg[accelerate] to the pyinstaller_base section is consistent with the PR objectives and simplifies dependency management.

@@ -99,7 +99,7 @@ PartSeg = "PartSeg:napari.yaml"

[project.optional-dependencies]
accelerate = [
"PyOpenGL-accelerate>=3.1.5 ; platform_machine != 'arm64'",
# "PyOpenGL-accelerate>=3.1.5 ; platform_machine != 'arm64'",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the commented-out dependency.

To maintain clean code, remove the commented-out line for PyOpenGL-accelerate.

-#    "PyOpenGL-accelerate>=3.1.5 ; platform_machine != 'arm64'",
Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
# "PyOpenGL-accelerate>=3.1.5 ; platform_machine != 'arm64'",

@Czaki Czaki added the skip check PR title skip spellcheking PR title label Jul 18, 2024
@Czaki Czaki merged commit aac66a7 into develop Jul 18, 2024
67 of 71 checks passed
@Czaki Czaki deleted the remove_pyopengl_accelerate branch July 18, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip check PR title skip spellcheking PR title
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant