-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: remove PyOpenGL-accelerate from dependencies because of numpy incompatibility #1155
Conversation
WalkthroughThe changes in the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have skipped reviewing this pull request. We don't review packaging changes - Let us know if you'd like us to change this.
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- pyproject.toml (2 hunks)
Additional comments not posted (1)
pyproject.toml (1)
117-117
: LGTM!The addition of
PartSeg[accelerate]
to thepyinstaller_base
section is consistent with the PR objectives and simplifies dependency management.
@@ -99,7 +99,7 @@ PartSeg = "PartSeg:napari.yaml" | |||
|
|||
[project.optional-dependencies] | |||
accelerate = [ | |||
"PyOpenGL-accelerate>=3.1.5 ; platform_machine != 'arm64'", | |||
# "PyOpenGL-accelerate>=3.1.5 ; platform_machine != 'arm64'", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the commented-out dependency.
To maintain clean code, remove the commented-out line for PyOpenGL-accelerate
.
-# "PyOpenGL-accelerate>=3.1.5 ; platform_machine != 'arm64'",
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
# "PyOpenGL-accelerate>=3.1.5 ; platform_machine != 'arm64'", |
The
PyOpenGL-accelerate
wheels are built against NumPy 1.x that make it impossible to switch to 3D rendering.Summary by CodeRabbit
accelerate
andpyinstaller_base
to ensure better compatibility and performance.