chore: Proper use enum in checking new version #1123
Conversation
WalkthroughThe changes involve updating message box configurations and restructuring the mock message box class for better organization. Specifically, Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
|
🧙 Sourcery has finished reviewing your pull request! Tips
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- package/PartSeg/_launcher/check_version.py (1 hunks)
Additional comments not posted (5)
package/PartSeg/_launcher/check_version.py (5)
72-77: Use ofQMessageBox.Icon.Informationis correct.The change from
QMessageBox.InformationtoQMessageBox.Icon.Informationis correct and aligns with PyQt5/PySide2 conventions.
77-77: Use ofQMessageBox.StandardButton.Ok | QMessageBox.StandardButton.Ignoreis correct.The change from
QMessageBox.Ok | QMessageBox.IgnoretoQMessageBox.StandardButton.Ok | QMessageBox.StandardButton.Ignoreis correct and aligns with PyQt5/PySide2 conventions.
81-86: Use ofQMessageBox.StandardButton.Informationis correct.The change from
QMessageBox.InformationtoQMessageBox.StandardButton.Informationis correct and aligns with PyQt5/PySide2 conventions.
86-86: Use ofQMessageBox.StandardButton.Ignoreis correct.The change from
QMessageBox.IgnoretoQMessageBox.StandardButton.Ignoreis correct and aligns with PyQt5/PySide2 conventions.
89-89: Correct usage ofQMessageBox.StandardButton.Ignorein the condition.The change from
QMessageBox.IgnoretoQMessageBox.StandardButton.Ignorein the condition is correct and aligns with PyQt5/PySide2 conventions.
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- package/PartSeg/_launcher/check_version.py (1 hunks)
- package/tests/test_PartSeg/test_check_release.py (1 hunks)
Additional comments not posted (7)
package/PartSeg/_launcher/check_version.py (5)
72-77: Correct use ofQMessageBox.Icon.Information.The change from
QMessageBox.InformationtoQMessageBox.Icon.Informationis correct and follows the updated API.
77-77: Correct use ofQMessageBox.StandardButton.Ok | QMessageBox.StandardButton.Ignore.The change from
QMessageBox.Ok | QMessageBox.IgnoretoQMessageBox.StandardButton.Ok | QMessageBox.StandardButton.Ignoreis correct and follows the updated API.
81-86: Correct use ofQMessageBox.Icon.Information.The change from
QMessageBox.InformationtoQMessageBox.Icon.Informationis correct and follows the updated API.
86-86: Correct use ofQMessageBox.StandardButton.Ok | QMessageBox.StandardButton.Ignore.The change from
QMessageBox.Ok | QMessageBox.IgnoretoQMessageBox.StandardButton.Ok | QMessageBox.StandardButton.Ignoreis correct and follows the updated API.
89-89: Correct use ofQMessageBox.StandardButton.Ignore.The change from
QMessageBox.IgnoretoQMessageBox.StandardButton.Ignoreis correct and follows the updated API.package/tests/test_PartSeg/test_check_release.py (2)
46-50: Correct restructuring ofMockMessageBox.StandardButton.The restructuring of
MockMessageBoxto include the nested classStandardButtonwith constantsInformation,Ok, andIgnoreis correct and improves organization.
51-52: Correct restructuring ofMockMessageBox.Icon.The restructuring of
MockMessageBoxto include the nested classIconwith the constantInformationis correct and improves organization.
|
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- package/tests/test_PartSeg/test_check_release.py (2 hunks)
Files skipped from review as they are similar to previous changes (1)
- package/tests/test_PartSeg/test_check_release.py
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1123 +/- ##
===========================================
+ Coverage 92.91% 92.93% +0.01%
===========================================
Files 205 205
Lines 32519 32519
===========================================
+ Hits 30215 30220 +5
+ Misses 2304 2299 -5 ☔ View full report in Codecov by Sentry. |
Summary by CodeRabbit
Bug Fixes
Refactor
MockMessageBoxclass for better organization of constants.