-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: Fix not bundling Font Awesome 6 Free-Solid-900.otf
file to executable
#1114
Conversation
WalkthroughThe recent changes introduce data file inclusion for the "fonticon_fa6" in the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant LauncherMain as launcher_main.py
participant LabelChoose as LabelChoose
User ->> LauncherMain: Start Application
LauncherMain ->> LabelChoose: Import and Instantiate
LauncherMain ->> LabelChoose: Call refresh()
Poem
Warning Review ran into problemsProblems (1)
Tip Early access features: enabledWe are currently testing the following features in early access:
Note:
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Font Awesome 6 Free-Solid-900.otf
file to executableFont Awesome 6 Free-Solid-900.otf
file to executable
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1114 +/- ##
===========================================
- Coverage 92.97% 92.95% -0.02%
===========================================
Files 205 205
Lines 32464 32464
===========================================
- Hits 30182 30177 -5
- Misses 2282 2287 +5 ☔ View full report in Codecov by Sentry. |
🧙 Sourcery has finished reviewing your pull request! Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- launcher.spec (1 hunks)
- package/PartSeg/launcher_main.py (2 hunks)
Files skipped from review due to trivial changes (1)
- launcher.spec
Additional comments not posted (2)
package/PartSeg/launcher_main.py (2)
28-28
: Import added forLabelChoose
.The import statement for
LabelChoose
fromPartSeg.common_gui.label_create
has been added.
50-52
: Instance creation and method call added forLabelChoose
.An instance of
LabelChoose
is created and itsrefresh
method is called. This appears to be correct and necessary for the intended functionality.
fix PARTSEG-TM
Summary by CodeRabbit
LabelChoose
UI component for improved label selection functionality.