Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Fix not bundling Font Awesome 6 Free-Solid-900.otf file to executable #1114

Merged
merged 3 commits into from
Jul 2, 2024

Conversation

Czaki
Copy link
Collaborator

@Czaki Czaki commented Jul 2, 2024

fix PARTSEG-TM

Summary by CodeRabbit

  • New Features
    • Integrated new data file collection for "fonticon_fa6" to enhance font icon support.
    • Added LabelChoose UI component for improved label selection functionality.

@Czaki Czaki added this to the 0.15.3 milestone Jul 2, 2024
Copy link
Contributor

coderabbitai bot commented Jul 2, 2024

Walkthrough

The recent changes introduce data file inclusion for the "fonticon_fa6" in the launcher.spec and initialize a new LabelChoose instance in launcher_main.py, which subsequently calls its refresh() method. These additions ensure necessary resources are packed and graphical user interface elements are updated as needed.

Changes

File Change Summary
launcher.spec Added collect_data_files("fonticon_fa6") to include additional font resources.
.../PartSeg/launcher_main.py Imported LabelChoose, instantiated it, and called the refresh() method for it.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant LauncherMain as launcher_main.py
    participant LabelChoose as LabelChoose
    User ->> LauncherMain: Start Application
    LauncherMain ->> LabelChoose: Import and Instantiate
    LauncherMain ->> LabelChoose: Call refresh()
Loading

Poem

In code’s embrace, new fonts we see,
LabelChoose refreshes, GUI glee.
Data collected, fonts align,
PartSeg’s launcher, looking fine.
As changes bloom, the software grows,
A rabbit’s hop where progress flows. 🌟

Warning

Review ran into problems

Problems (1)
  • Git: Failed to clone repository. Please contact CodeRabbit support.

Tip

Early access features: enabled

We are currently testing the following features in early access:

  • OpenAI gpt-4o model for code reviews and chat: OpenAI claims that this model is better at understanding and generating code than the previous models. We seek your feedback over the next few weeks before making it generally available.

Note:

  • You can enable or disable early access features from the CodeRabbit UI or by updating the CodeRabbit configuration file.
  • Please join our Discord Community to provide feedback and report issues.
  • OSS projects are currently opted into early access features by default.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Czaki Czaki changed the title Fix not bundling Font Awesome 6 Free-Solid-900.otf file to executable build: Fix not bundling Font Awesome 6 Free-Solid-900.otf file to executable Jul 2, 2024
Copy link

codecov bot commented Jul 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.95%. Comparing base (4dfd50a) to head (f310b38).
Report is 86 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1114      +/-   ##
===========================================
- Coverage    92.97%   92.95%   -0.02%     
===========================================
  Files          205      205              
  Lines        32464    32464              
===========================================
- Hits         30182    30177       -5     
- Misses        2282     2287       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Czaki Czaki marked this pull request as ready for review July 2, 2024 12:02
Copy link
Contributor

sourcery-ai bot commented Jul 2, 2024

🧙 Sourcery has finished reviewing your pull request!


Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.

Copy link

sonarcloud bot commented Jul 2, 2024

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 4dfd50a and f310b38.

Files selected for processing (2)
  • launcher.spec (1 hunks)
  • package/PartSeg/launcher_main.py (2 hunks)
Files skipped from review due to trivial changes (1)
  • launcher.spec
Additional comments not posted (2)
package/PartSeg/launcher_main.py (2)

28-28: Import added for LabelChoose.

The import statement for LabelChoose from PartSeg.common_gui.label_create has been added.


50-52: Instance creation and method call added for LabelChoose.

An instance of LabelChoose is created and its refresh method is called. This appears to be correct and necessary for the intended functionality.

@Czaki Czaki merged commit ecf008e into develop Jul 2, 2024
50 of 51 checks passed
@Czaki Czaki deleted the fix_bundle branch July 2, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant