chore: Fix jupyter failing test by using constraints #1093
Conversation
WalkthroughThis update ushers in a new chapter of configuration with Python 3.11, improving performance and embracing the latest features. It streamlines dependency management by updating paths, introducing the Changes
Recent Review DetailsConfiguration used: CodeRabbit UI Files selected for processing (1)
Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Czaki
changed the title
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @Czaki - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Docstrings: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review Status
Configuration used: CodeRabbit UI
Files selected for processing (1)
- azure-pipelines.yml (1 hunks)
Additional comments not posted (3)
azure-pipelines.yml (3)
100-100: The Python version has been updated to 3.11 for theNotebook_checkjob. This change aligns with the PR's objective to address failing tests by ensuring compatibility with Python 3.11.
103-103: The path for the pip constraints file has been updated torequirements/constraints_py3.11.txtfor theNotebook_checkjob. This update is crucial for ensuring that the correct versions of dependencies are used, which can help in resolving the failing tests issue.
110-111: The introduction of thePIP_CONSTRAINTenvironment variable with the valuerequirements/constraints_py3.11.txtis a significant addition. This variable explicitly specifies the constraints file to be used by pip during the dependency installation process, adding a layer of control over the versions of packages installed. This change is expected to reduce the likelihood of version conflicts that could lead to test failures.
There was a problem hiding this comment.
Actionable comments posted: 0
Review Status
Configuration used: CodeRabbit UI
Files selected for processing (3)
- .azure-pipelines/tests.yaml (2 hunks)
- azure-pipelines.yml (1 hunks)
- tox.ini (2 hunks)
Files skipped from review as they are similar to previous changes (1)
- azure-pipelines.yml
Additional comments not posted (5)
.azure-pipelines/tests.yaml (3)
6-6: The update to Python 3.11 is correctly specified in theUsePythonVersiontask. This change aligns with the PR objectives to ensure compatibility with Python 3.11.
9-9: The pip constraints file path is correctly updated toconstraints_py3.11.txt, ensuring that the correct dependencies are used for Python 3.11. However, there's a potential inconsistency in thePIP_CONSTRAINTenvironment variable setting.Please verify that the
PIP_CONSTRAINTenvironment variable in the "Run Tox" script step should also referenceconstraints_py3.11.txtinstead ofconstraints_py3.9.txtto align with the Python 3.11 update.
19-19: The tox environment name is updated topy311-PyQt5-azure, which correctly reflects the new Python version. However, ensure that all references to the tox environment throughout the project are updated accordingly.tox.ini (2)
104-104: Adding Python 3.11 support in thetestenvconfigurations is a necessary update that aligns with the PR objectives. This change ensures that tests can run against the latest Python version.
113-113: The update to include thejupyterdependency in thetestenv:jupyterenvironment is appropriate for ensuring that Jupyter notebooks can be tested correctly. However, it's important to verify that thematplotlibdependency is also required for the Jupyter environment to function as intended.Please confirm that the
matplotlibdependency is necessary for the Jupyter test environment. If it is not required, consider removing it to streamline the dependencies.
Czaki
changed the title
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1093 +/- ##
===========================================
+ Coverage 92.81% 92.83% +0.01%
===========================================
Files 205 205
Lines 32469 32469
===========================================
+ Hits 30137 30142 +5
+ Misses 2332 2327 -5 ☔ View full report in Codecov by Sentry. |
Summary by CodeRabbit
PIP_CONSTRAINTfor specifying pip constraints.tox.ini.jupyterdependency in thejupytertest environment configuration.tox.ini.pygmentsdependency version in the project configuration file.