ci: Add python 3.12 testing #1087
Conversation
WalkthroughThis update encompasses a plethora of package version upgrades, extends Python support up to 3.12, and bolsters error handling and plugin registration in the PartSeg project. Noteworthy improvements include robust error checks in batch processing and a refined approach to managing plugin entry points, ensuring smoother operations and increased stability. Changes
Recent Review DetailsConfiguration used: CodeRabbit UI Files selected for processing (2)
Files skipped from review as they are similar to previous changes (2)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey Czaki - Here's my review!
General suggestions:
- Verify all project dependencies for compatibility with Python 3.12 to avoid potential integration issues.
- Consider the impact of adding Python 3.12 on CI build times and resource usage, and adjust as necessary to maintain efficient CI operations.
- Ensure that any Python 3.12 specific dependencies or version constraints are accounted for in the upgrade process.
Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨
| @@ -39,7 +39,7 @@ jobs: | |||
| strategy: | |||
| fail-fast: false | |||
| matrix: | |||
| python_version: ["3.8", "3.9", "3.10", "3.11"] | |||
| python_version: ["3.8", "3.9", "3.10", "3.11", "3.12"] | |||
There was a problem hiding this comment.
question (llm): Adding Python 3.12 to the testing matrix is a great move for forward compatibility. However, it's important to ensure that all dependencies of the project are compatible with Python 3.12. Have we verified that all dependencies support Python 3.12, or are there any known issues?
| @@ -35,7 +35,7 @@ jobs: | |||
| pip install -U uv | |||
| flags=(--extra pyqt5 --extra pyqt6 --extra pyside2 --extra pyside6 --extra test --extra pyinstaller) | |||
|
|
|||
| for pyv in 3.8 3.9 3.10 3.11; do | |||
| for pyv in 3.8 3.9 3.10 3.11 3.12; do | |||
There was a problem hiding this comment.
question (llm): Including Python 3.12 in the upgrade-dependencies workflow is crucial for maintaining up-to-date dependencies. However, it's equally important to ensure that the upgrade process accounts for any Python 3.12 specific dependencies or version constraints. Are there any additional steps or considerations needed for Python 3.12 in the upgrade process?
| @@ -39,7 +39,7 @@ jobs: | |||
| strategy: | |||
| fail-fast: false | |||
| matrix: | |||
| python_version: ["3.8", "3.9", "3.10", "3.11"] | |||
| python_version: ["3.8", "3.9", "3.10", "3.11", "3.12"] | |||
There was a problem hiding this comment.
suggestion (llm): Expanding the testing matrix to include Python 3.12 across different operating systems is commendable for ensuring cross-platform compatibility. However, have we considered the potential impact on CI build times and resource usage? It might be beneficial to monitor these aspects to ensure efficient CI operations.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files ignored due to path filters (2)
pyproject.tomlis excluded by:!**/*.tomltox.iniis excluded by:!**/*.ini
Files selected for processing (12)
- .github/workflows/tests.yml (2 hunks)
- .github/workflows/upgrade-dependencies.yml (1 hunks)
- requirements/constraints_py3.10.txt (6 hunks)
- requirements/constraints_py3.10_pydantic_1.txt (6 hunks)
- requirements/constraints_py3.11.txt (5 hunks)
- requirements/constraints_py3.11_pydantic_1.txt (5 hunks)
- requirements/constraints_py3.12.txt (1 hunks)
- requirements/constraints_py3.12_pydantic_1.txt (1 hunks)
- requirements/constraints_py3.8.txt (4 hunks)
- requirements/constraints_py3.8_pydantic_1.txt (4 hunks)
- requirements/constraints_py3.9.txt (4 hunks)
- requirements/constraints_py3.9_pydantic_1.txt (4 hunks)
Additional comments: 48
.github/workflows/upgrade-dependencies.yml (1)
- 38-38: Adding Python 3.12 to the loop iteration for upgrading dependencies is a positive step towards ensuring compatibility with the latest Python version. Ensure that all dependencies and their respective constraint files are correctly managed for Python 3.12, as this version might introduce changes that affect package compatibility.
.github/workflows/tests.yml (2)
- 42-42: Adding Python 3.12 to the test matrix in the
base-testjob is a crucial step towards ensuring compatibility with the latest Python version. This broadens the testing scope and helps identify potential compatibility issues early.- 81-81: Incorporating Python 3.12 into the test matrix for the
base-test-mainjob expands the project's testing capabilities to include the latest Python version. This is an important step in ensuring that the project remains compatible with new Python releases.requirements/constraints_py3.11_pydantic_1.txt (5)
- 21-21: The update of
buildto version1.1.1is noted. Ensure that this version is compatible with the project's build system and does not introduce any breaking changes.- 87-87: Updating
ipythonto8.22.2could enhance interactive debugging and execution. Verify that this version works well with other interactive tools used in the project, such as Jupyter notebooks.- 121-121: The upgrade of
magicguito0.8.2should be checked for compatibility with the project's GUI components, especially ifnapariplugins are extensively used.- 253-253: The update of
pyinstaller-hooks-contribto2024.2is crucial for ensuring that the project's executable builds include the correct versions of dependencies. Confirm that this update does not affect the build process or the resulting executables.- 284-284: Upgrading
python-dateutilto2.9.0.post0might impact date and time handling in the project. It's important to verify that this update does not introduce regressions in date/time processing functionalities.requirements/constraints_py3.11.txt (5)
- 23-23: The update of
buildfrom1.0.3to1.1.1is noted. Ensure that this version is compatible with the project's build system and does not introduce breaking changes.- 89-89: Updating
ipythonto8.22.2should be checked for compatibility with the project's interactive Python sessions, especially regarding new features or deprecated functionalities.- 123-123: The
magicguiversion bump to0.8.2should be verified for compatibility with the project's GUI components, ensuring that all functionalities work as expected.- 257-257: The update of
pyinstaller-hooks-contribto2024.2needs to be checked for any potential issues with the project's PyInstaller hooks, especially for new or updated dependencies.- 288-288: Upgrading
python-dateutilto2.9.0.post0should be carefully reviewed for date and time handling within the project, ensuring no regressions or unexpected behavior changes.requirements/constraints_py3.10_pydantic_1.txt (5)
- 21-21: The update of
buildfrom 1.0.3 to 1.1.1 should be checked for compatibility with the project's build system and any scripts that rely on it.- 93-93: Updating
ipythonfrom 8.22.1 to 8.22.2 is a minor version change. Ensure that this update does not introduce any breaking changes or incompatibilities with the project's interactive Python sessions or scripts.- 127-127: The update of
magicguifrom 0.8.1 to 0.8.2 should be verified for compatibility with the project's GUI components, especially ifmagicguiis used extensively for UI elements.- 259-259: The update of
pyinstaller-hooks-contribfrom 2024.1 to 2024.2 should be checked to ensure that all custom hooks and third-party libraries used in the project are still compatible and function correctly after the update.- 290-290: Updating
python-dateutilfrom 2.8.2 to 2.9.0.post0 involves a minor version change. It's important to verify that this update does not affect the project's date and time handling, especially in critical functionalities.requirements/constraints_py3.10.txt (5)
- 23-23: The update of
buildfrom 1.0.3 to 1.1.1 should be verified for compatibility with the project's build system.- 95-95: Updating
ipythonfrom 8.22.1 to 8.22.2 is a minor change, likely for bug fixes or minor improvements. Ensure no breaking changes affect the project's interactive sessions.- 129-129: The update of
magicguifrom 0.8.1 to 0.8.2 should be checked for compatibility with the project's GUI components, especially ifmagicguiis used extensively.- 263-263: Updating
pyinstaller-hooks-contribfrom 2024.1 to 2024.2 might introduce changes to the hooks available for PyInstaller. Verify that all necessary hooks for the project's dependencies are still supported.- 294-294: The update of
python-dateutilto 2.9.0.post0 is notable. Ensure this version does not introduce any backward-incompatible changes that could affect date and time handling in the project.requirements/constraints_py3.9_pydantic_1.txt (4)
- 21-21: The update of
buildfrom1.0.3to1.1.1seems appropriate. Ensure that this version is compatible with other dependencies and does not introduce breaking changes.- 131-131: Updating
magicguito0.8.2is a minor version change, which typically includes bug fixes and new features. Verify that the new features or fixes do not adversely affect existing functionality.- 263-263: The update of
pyinstaller-hooks-contribto2024.2should be checked for compatibility withpyinstallerand other related dependencies. This package plays a crucial role in the freezing process, and any incompatibilities could lead to build issues.Verification successful
The explicit listing of
pyinstaller==6.4.0andpyinstaller-hooks-contrib==2024.2in therequirementsfiles for various Python versions, along with the absence of documented compatibility issues in the repository's documentation, changelogs, or workflow configurations, suggests that these versions are intended to be compatible. However, this does not guarantee the absence of any issues not documented within the repository.* 294-294: Updating `python-dateutil` to `2.9.0.post0` introduces a post-release version. While post-releases typically include minor fixes, ensure that this version does not conflict with other packages requiring `python-dateutil`, especially in terms of version specifications.Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Check for known issues with pyinstaller-hooks-contrib 2024.2 and compatibility with pyinstaller 6.4.0 grep -R "pyinstaller-hooks-contrib 2024.2 issues" documentation/Length of output: 114
Script:
#!/bin/bash # Search the entire repository for mentions of pyinstaller-hooks-contrib 2024.2 and pyinstaller to find any notes on compatibility or known issues. grep -Ri "pyinstaller-hooks-contrib 2024.2" ./ grep -Ri "pyinstaller" ./Length of output: 12898
Verification successful
The verification process did not reveal direct conflicts with the
python-dateutilversion2.9.0.post0across the checked requirements files. The only specific version found was2.8.2inrequirements/constraints_py3.11_docs.txt, which does not directly conflict but indicates a preference for an older version in that particular context. The review comment's advice to ensure no conflicts arise due to the version update is prudent, but no direct evidence of conflicts was found. Therefore, the review comment remains relevant and accurate in advising caution, but no direct version conflicts were identified.Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Check for conflicts with python-dateutil 2.9.0.post0 in other requirements files grep -R "python-dateutil" requirements/*.txt | grep -v "2.9.0.post0"Length of output: 1525
requirements/constraints_py3.9.txt (4)
- 23-23: The update of the
buildpackage version to1.1.1is approved. It likely introduces improvements or bug fixes compatible with the project's requirements.- 133-133: The minor version update of
magicguito0.8.2is approved, indicating non-breaking changes that could benefit the project.- 267-267: The update of
pyinstaller-hooks-contribto version2024.2is approved, suggesting incremental improvements that align with maintaining project compatibility.- 298-298: Updating
python-dateutilto2.9.0.post0is approved, as post-releases often include critical fixes that enhance stability and compatibility.requirements/constraints_py3.8_pydantic_1.txt (4)
- 23-23: The update of
buildfrom1.0.3to1.1.1is noted. Ensure that this version is compatible with the project's build system and does not introduce any breaking changes.- 135-135: The update of
magicguifrom0.8.1to0.8.2should be checked for compatibility with the project's GUI components, especially ifmagicguiis used extensively.- 272-272: Updating
pyinstaller-hooks-contribfrom2024.1to2024.2could affect the project's packaging process. Verify that all hooks required for the project are still supported and function correctly.- 303-303: The update of
python-dateutilto2.9.0.post0should be carefully reviewed for compatibility with date and time handling in the project. This is especially important if the project relies on specific behaviors ofpython-dateutil.requirements/constraints_py3.8.txt (4)
- 25-25: The update of
buildfrom 1.0.3 to 1.1.1 seems appropriate. Ensure that this version is compatible with other dependencies and the project's requirements.- 137-137: The update of
magicguifrom 0.8.1 to 0.8.2 is minor and likely includes bug fixes or minor improvements. Verify that there are no breaking changes affecting the project.- 276-276: Updating
pyinstaller-hooks-contribfrom 2024.1 to 2024.2 should be safe, assuming it's primarily bug fixes or minor enhancements. Double-check for any compatibility issues withpyinstaller.- 307-307: The update of
python-dateutilto 2.9.0.post0 introduces a post-release version. Ensure this version doesn't introduce any unexpected behaviors, especially since it's a post-release which might include specific fixes or changes.requirements/constraints_py3.12_pydantic_1.txt (8)
- 154-154: Ensure that
numpy==1.26.4is compatible with Python 3.12. While numpy generally maintains good forward compatibility, it's crucial to verify this specific version against Python 3.12 to avoid potential runtime issues.- 191-191:
pandas==2.2.1should be checked for compatibility with Python 3.12. Given pandas' critical role in data manipulation, confirming its compatibility ensures the stability of any data-driven functionality in the project.- 260-260:
pyqt5==5.15.10needs verification for Python 3.12 compatibility. PyQt5, being a significant GUI framework, its compatibility is essential for any GUI components of the project.- 265-265: Check
pyqt6==6.6.1for compatibility with Python 3.12. As the successor to PyQt5, ensuring its compatibility is crucial for projects planning to migrate or use PyQt6 features.- 270-270: Verify
pyside2==5.13.2against Python 3.12. Given the choice between PyQt and PySide for Qt bindings in Python, confirming PySide2's compatibility is important for projects using it.- 271-271: Ensure
pyside6==6.6.2is compatible with Python 3.12. As with PyQt6, verifying PySide6's compatibility is essential for projects leveraging its features.- 278-278:
pytest==8.0.2should be checked for compatibility with Python 3.12. Given pytest's widespread use for testing in Python projects, confirming its compatibility is crucial for maintaining a robust testing pipeline.- 1-432: Overall, the file appears to be well-structured and follows the expected format for a Python dependency constraint file. However, it's important to ensure that all dependencies listed are indeed required for the project and that their versions are not only compatible with Python 3.12 but also with each other to avoid dependency conflicts.
requirements/constraints_py3.12.txt (1)
- 1-437: Overall, the
constraints_py3.12.txtfile is well-structured and clearly specifies the versions of dependencies required for Python 3.12 support. The comments indicating the source of each dependency are helpful for understanding the dependency tree. No issues were found with the specified versions or the structure of the file.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1087 +/- ##
===========================================
+ Coverage 92.81% 92.95% +0.13%
===========================================
Files 205 205
Lines 32475 32480 +5
===========================================
+ Hits 30141 30191 +50
+ Misses 2334 2289 -45 ☔ View full report in Codecov by Sentry. |
|
Summary by CodeRabbit