-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Allow to use newer release of build docs dependencies #1057
Conversation
Important Auto Review SkippedReview was skipped due to path filters Files ignored due to path filters (1)
WalkthroughThe project has been updated to accommodate Python 3.11, involving workflow modifications for dependency compilation and adjustments in documentation build settings. The changes include specifying new compile options, updating the operating system for documentation builds to Ubuntu 22.04, and introducing a constraints file tailored for Python 3.11 to manage package versions. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files ignored due to path filters (1)
setup.cfg
is excluded by:!**/*.cfg
Files selected for processing (3)
- .github/workflows/upgrade-dependencies.yml (1 hunks)
- .readthedocs.yml (1 hunks)
- requirements/constraints_py3.11_docs.txt (1 hunks)
Additional comments: 5
.readthedocs.yml (3)
- 20-20: The operating system has been updated to
ubuntu-22.04
.- 22-22: The Python version has been updated to
3.11
.- 28-32: The Python requirements have been updated to use
constraints_py3.11_docs.txt
and an extra requirement fordocs
has been added..github/workflows/upgrade-dependencies.yml (1)
- 56-56: A new command has been added to compile Python dependencies for version 3.11 with specific options and extras for documentation.
requirements/constraints_py3.11_docs.txt (1)
- 1-481: The constraints file
constraints_py3.11_docs.txt
has been generated with Python 3.11 and includes a comprehensive list of dependencies with pinned versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (2)
- requirements/constraints_py3.11_docs.txt (1 hunks)
- requirements/version_denylist.txt (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- requirements/constraints_py3.11_docs.txt
Additional comments: 1
requirements/version_denylist.txt (1)
- 11-15: The additions to the denylist for
sphinxcontrib-*
packages seem appropriate given the context of the file. However, ensure that the specified versions are indeed incompatible or problematic with Python 3.11, as this file's purpose is to prevent installation of these versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files ignored due to path filters (1)
tox.ini
is excluded by:!**/*.ini
Files selected for processing (2)
- package/PartSeg/common_gui/universal_gui_part.py (1 hunks)
- requirements/constraints_py3.11_docs.txt (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- requirements/constraints_py3.11_docs.txt
Additional comments: 2
package/PartSeg/common_gui/universal_gui_part.py (2)
- 86-86: The type hint for the
enum
parameter in theEnumComboBox
class__init__
method has been removed. Ensure that this change does not affect any other parts of the codebase where type hints are expected or required for static type checking or documentation purposes.- 86-86: The deprecation warning message in the
EnumComboBox
class__init__
method has been updated to suggest usingsuperqt.QEnumComboBox
instead. Confirm that this message is clear and that the suggested alternative is indeed the preferred option. Also, ensure that there is a migration path or documentation available for users to transition to the new class.
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
Summary by CodeRabbit