Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Do not allow to select and render corrupted batch plans #1015

Merged
merged 20 commits into from
Aug 25, 2023

Conversation

Czaki
Copy link
Collaborator

@Czaki Czaki commented Aug 24, 2023

Add check if the batch plan is correct (not missing some plugin), and if yes, do not render its preview or do not allow a user to select it as batch plan.

@Czaki Czaki added this to the 0.15.2 milestone Aug 24, 2023
@Czaki Czaki changed the title Do not render and allow to select corrupted batch plans fix: Do not render and allow to select corrupted batch plans Aug 24, 2023
@deprecated-napari-hub-preview-bot
Copy link

deprecated-napari-hub-preview-bot bot commented Aug 24, 2023

Preview page for your plugin is ready here:
https://preview.napari-hub.org/4DNucleome/PartSeg/1015
Updated: 2023-08-25T16:57:15.929398

@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Attention: Patch coverage is 95.75758% with 7 lines in your changes missing coverage. Please review.

Project coverage is 92.25%. Comparing base (ae9a4d0) to head (badbdf4).
Report is 146 commits behind head on develop.

Files with missing lines Patch % Lines
...ckage/PartSeg/_roi_analysis/prepare_plan_widget.py 83.33% 5 Missing ⚠️
package/PartSegCore/analysis/calculation_plan.py 93.10% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1015      +/-   ##
===========================================
+ Coverage    92.22%   92.25%   +0.02%     
===========================================
  Files          206      206              
  Lines        32179    32318     +139     
===========================================
+ Hits         29677    29814     +137     
- Misses        2502     2504       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Czaki Czaki changed the title fix: Do not render and allow to select corrupted batch plans fix: Do not allow to select and render corrupted batch plans Aug 24, 2023
@sonarcloud
Copy link

sonarcloud bot commented Aug 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Czaki Czaki merged commit df3663c into develop Aug 25, 2023
44 checks passed
@Czaki Czaki deleted the fix_import_problem branch August 25, 2023 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant