Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: improve exports and abstract class #346

Merged
merged 5 commits into from
May 18, 2020
Merged

fix!: improve exports and abstract class #346

merged 5 commits into from
May 18, 2020

Conversation

ethanve
Copy link
Contributor

@ethanve ethanve commented May 18, 2020

Mostly just to bump to v1

@ethanve ethanve requested review from jquense and taion May 18, 2020 20:40
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@ethanve
Copy link
Contributor Author

ethanve commented May 18, 2020

@taion any idea?

/home/travis/build/4Catalyzer/graphql-subscription-server/test/AsyncQueue.test.ts
  1:1  error  Definition for rule 'import/no-extraneous-dependencies' was not found  import/no-extraneous-dependencies
/home/travis/build/4Catalyzer/graphql-subscription-server/test/RedisSubscriber.test.ts
  1:1  error  Definition for rule 'import/no-extraneous-dependencies' was not found  import/no-extraneous-dependencies
/home/travis/build/4Catalyzer/graphql-subscription-server/test/__mocks__/redis.ts
  1:1  error  Definition for rule 'import/no-extraneous-dependencies' was not found  import/no-extraneous-dependencies

@ethanve
Copy link
Contributor Author

ethanve commented May 18, 2020

the package.json does have eslint-plugin-import as a dep

@taion
Copy link
Contributor

taion commented May 18, 2020

it's because the config is missing the import plugin. why? because...

4catalyzer-typescript works differently from 4catalyzer-flow – it's an add-on to an existing config, like w/ https://github.com/4Catalyzer/graphql-node-resource/blob/1566ebc6cd842bc9617c2fc4b3fde2ab1ad9a294/.eslintrc#L4

so add back eslint-config-4catalyzer

@ethanve ethanve merged commit c86d4e0 into master May 18, 2020
@ethanve ethanve deleted the fixes branch May 18, 2020 21:36
jquense pushed a commit that referenced this pull request May 18, 2020
# [1.0.0](v0.11.0...v1.0.0) (2020-05-18)

* fix!: improve exports and abstract class (#346) ([c86d4e0](c86d4e0)), closes [#346](#346)

### BREAKING CHANGES

* convert to typescript
@jquense
Copy link
Member

jquense commented May 18, 2020

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants