Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix subscribe error handling #21

Merged
merged 1 commit into from
Aug 11, 2018
Merged

Fix subscribe error handling #21

merged 1 commit into from
Aug 11, 2018

Conversation

taion
Copy link
Contributor

@taion taion commented Aug 10, 2018

No description provided.

taion
taion commented Aug 10, 2018
View reviewed changes
src/AuthorizedSocketConnection.js
this.subscriptions.delete(id);
throw err;
if (err instanceof GraphQLError) {
resultOrStream = { errors: [err] };
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

createSourceEventStream will occasionally just throw GraphQLError

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/graphql/graphql-js/blob/4fd9260efa247d60f74f3ebc259c8a3c2b03af61/src/subscription/subscribe.js#L272-L274

these all get caught and wrapped from the subscribe function, but not from here

@taion taion merged commit fe9308b into master Aug 11, 2018
@taion taion deleted the error-handling branch August 11, 2018 02:38
jquense pushed a commit that referenced this pull request Aug 13, 2018
@semantic-release-bot
chore(release): 0.7.1 [skip ci]
09ad39c 
<a name="0.7.1"></a>
## [0.7.1](v0.7.0...v0.7.1) (2018-08-13)

### Bug Fixes

* Fix subscribe error handling ([#21](#21)) ([fe9308b](fe9308b))
@jquense
Copy link
Member

jquense commented Aug 13, 2018

🎉 This PR is included in version 0.7.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jquense jquense jquense approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@taion @jquense