-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
react-redux
dependency bug
#244
Comments
@rcambrj Can you also check whether you're using |
Can confirm this is the problem ( |
Ok. |
I'm not really sure what the best way to deal with this is, to be honest. Ideally I don't want to force users to have to install The incompatibility is an issue, though. Not sure what the right answer is. |
It's something that would come up pretty early on, if I'm not mistaken, so
perhaps a more useful error message, mentioning the compatible version,
would be OK?
Op do 21 feb. 2019 om 15:16 schreef Jimmy Jia <[email protected]>
… I'm not really sure what the best way to deal with this is, to be honest.
Ideally I don't want to force users to have to install react-redux and
redux on their own, because it's possible to use Found without directly
interacting with Redux.
The incompatibility is an issue, though. Not sure what the right answer is.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#244 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAvG8IgCHu7WLoPGWLhMfZCZkQSQ1gOyks5vPqpGgaJpZM4bG5xj>
.
|
Hmm, I'm not sure how we'd do that though. Like check that our |
@taion I guess so. If |
I think I understand: the error is thrown before getting to found's logic.
Right? I suppose the prop expectations could be made looser, and a custom check made later on, it's a bit smelly though. |
Right, but we don't know if that's because you've set up the wrong version of Redux, or if it's because you just didn't render a |
@taion a store was being provided via context as a result of wrapping with a |
Right, but it's not the same context API, right? React Redux v5 uses the old context API, while React Redux v6 uses the new one. They don't inter-operate as expected. |
Having the same issue but using react-redux @5 |
If you're using React Redux v5, make sure you're still using the v0.3.x releases here. |
on second thought, let's do make this a peer dep. things work with 5, 6, and 7 equally now that we're not longer hacking around stuff in the alphas |
ugh, on third thought, this makes things quite clunky. i'm going to explicitly document this caveat instead and suggest some workarounds |
found
has a bug when it hasreact-redux
added in its dependencies instead of making it apeerDependency
.This results in
found
connect()
-ing to a different context and waiting for a<Provider store/>
in that context but the<Provider/>
that's instantiated incontainer
is from a differentnode_module
so it is therefore in an entirely different context and sofound
throws an error that<Provider store/>
is not found infound
's context.For example, with such
node_modules
structure:The original bug reporter is @rcambrj , he can answer further questions.
The text was updated successfully, but these errors were encountered: