Add Memory-ish protocol #44
Conversation
|
context: we use this in an Electron app where there is no url bar, the session storage is so ctrl-r works |
taion
force-pushed
the
memory-protocol
branch
from
598857d
to
6707406
Compare
|
I updated the code a bit. How does this look? |
src/MemoryProtocol.js
Outdated
|
|
||
| // Checking instanceof Array is okay because we make the array. | ||
| if ( | ||
| stack instanceof Array && |
There was a problem hiding this comment.
This is still weird :P what's wrong with isArray?
There was a problem hiding this comment.
requires a polyfill for older browsers, no? i don't have babel-runtime here... not sure what the right thing is
There was a problem hiding this comment.
how far back are you going? isArray is ie9+
| ...this._stack[this._index], | ||
| action: 'POP', | ||
| index: this._index, | ||
| delta, |
There was a problem hiding this comment.
So I originally did this sticking index and delta on location, but what's the value in doing so?
There was a problem hiding this comment.
in principle for consistency with browser protocol... e.g. if you want to animate differently based on whether delta is positive or negative
not sure if index has any purpose... really just from remix-run/history#36 and remix-run/history#334
|
Good to go on my end |
|
lgtm |
Admittedly this is more of a SessionProtocol, It’s probably easy to write a pure memory one in terms of the this, but meh