forked from gregberge/svgr
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pull] main from gregberge:main #1
Open
pull
wants to merge
70
commits into
47-studio-org:main
Choose a base branch
from
gregberge:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+32,361
−64,804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Run `npm install` * Add "@svgr/babel-preset" to "@svgr/core" dependencies
This updates the "Repository" links on npmjs.com package pages; right now, following those links gives a redirect, "Branch master was renamed to main."
Installing @svgr/core with Yarn Modern (Yarn 2+) gives the following warning: ``` ➤ YN0002: │ @svgr/core@npm:6.4.0 doesn't provide @babel/core (p0b84c), requested by @svgr/babel-preset ``` Fixes #785
This reverts commit 8b9edc4.
docs(a11y): revert #750 and add accessibility documentation for `svgProps` override
chore: upgrade deps
docs: document remix configuration
The new installation instructions are for a more advanced configuration than originally appeared in these docs, but the original did not actually work in Next 13, and the workaround took nearly as much code, so I've stuck with the slightly longer config here.
* Allow specifying `jsxRuntimeImport` in config, see #801 I need to have a config which isn't currently supported * Allow specifying a single specifier for custom imports, see #801 `hyperapp-jsx-pragma` uses the default export so we need to `import h from "hyperapp-jsx-pragma"`, not `import { h } from "hyperapp-jsx-pragma"`
BREAKING CHANGE: svgr now requires Node.js v14+
BREAKING CHANGE: plugin-jsx is no longer included by default in core
…e settings in playground chore(website): code style
chore(api): upgrade deps to latest v7
chore(website): add dimensions, exportType, namedExport and jsxRuntime settings in playground
BREAKING CHANGE: index template now receives an array of objects containing both the created component path (`path`) and the original SVG path (`originalPath`)
Generate `import type` as opposed to `import` when the typescript flag is present. Accomplished this by adding `importKind` parameter to the `getOrCreateImport` method.
When updating the imports of react-native-svg there is no check on the importKind. This would cause a wrong update import and a crash in the cli.
Signed-off-by: Yash Srivastav <[email protected]>
Fixed next.config.js example to a working version per this: #860 (comment) Co-authored-by: Jari Mustonen <[email protected]>
* Update nextjs docs for TypeScript support instructions * Add declaration for SVG module with '*.svg?url' import method, from next/image
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )