-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ [Feature] 지원자 목록 확인 API #804
The head ref may contain hidden characters: "real-\uC9C0\uC6D0\uC790\uBAA9\uB85D-\uD655\uC778-API"
Changes from all commits
6951e54
65e38f4
8d66be6
890623c
57174df
9799cb0
74484aa
9b8eb08
d88f132
c705c18
67042ba
0b26348
5377b1a
952c53e
5c7b648
9c824f8
d17abe4
24286e6
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,7 +3,6 @@ | |
import javax.persistence.Column; | ||
import javax.persistence.DiscriminatorValue; | ||
import javax.persistence.Entity; | ||
import javax.persistence.Id; | ||
|
||
import gg.data.recruit.recruitment.Question; | ||
import lombok.NoArgsConstructor; | ||
|
@@ -12,10 +11,6 @@ | |
@NoArgsConstructor(access = lombok.AccessLevel.PROTECTED) | ||
@DiscriminatorValue("TEXT") | ||
public class ApplicationAnswerText extends ApplicationAnswer { | ||
|
||
@Id | ||
private Long id; | ||
Kimhan-nah marked this conversation as resolved.
Show resolved
Hide resolved
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 여기 ID빠지면 flyway도 수정해줘야 하지 않나요?? 여기 ID값이 있으면 applicationAnswer삭제시에 연결된 applicationAnswerText나 applicationAnswerCheckList에 삭제쿼리가 같이 안나간다는거죠? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 넵 그렇습니다 우선 id 컬럼 자체는 부모 엔티티에 정의되어 있으면 자동상속이 이루어지는것 같습니다. 문제가 되는 부분이라면 원래대로 롤백할게요. flyway는 동일하게 작동합니다 |
||
|
||
@Column(length = 1000) | ||
private String answer; | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이건 set으로 하신 이유가 따로 있나요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
n+1 때문에 엔티티 그래프로 "applicationAnswers", "applicationAnswers.question.checkLists" 데이터를 조인하는 과정에서 여러 리스트 자료를 명시하는게 허용이 안되더라구요 checkLists는 이미 구현된 내용이고 applicationAnswers는 이번에 양방향을 추가한 내용이기 때문에 해당 부분을 set으로 대체했습니다.