Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] recruit status change api #781

Merged
merged 5 commits into from
Mar 29, 2024
Merged

[FEAT] recruit status change api #781

merged 5 commits into from
Mar 29, 2024

Conversation

wken5577
Copy link
Contributor

๐Ÿ“Œ ๊ฐœ์š”

  • recruit ๋ชจ์ง‘ ์ข…๋ฃŒ ํ† ๊ธ€ api์ž…๋‹ˆ๋‹ค

๐Ÿ’ป ์ž‘์—…์‚ฌํ•ญ

โœ… ๋ณ€๊ฒฝ๋กœ์ง

๐Ÿ’กIssue ๋ฒˆํ˜ธ

@wken5577 wken5577 self-assigned this Mar 28, 2024
@wken5577 wken5577 added the enhancement New feature or request label Mar 28, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests โœ…

Project coverage is 74.97%. Comparing base (307954e) to head (20ce835).
Report is 22 commits behind head on dev.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev     #781      +/-   ##
============================================
+ Coverage     73.39%   74.97%   +1.58%     
- Complexity     1050     1075      +25     
============================================
  Files           363      363              
  Lines          4770     4772       +2     
  Branches        394      396       +2     
============================================
+ Hits           3501     3578      +77     
+ Misses         1095     1017      -78     
- Partials        174      177       +3     
Flag Coverage ฮ”
integrationTest 69.53% <100.00%> (+1.60%) โฌ†๏ธ
unitTest 32.18% <0.00%> (-0.02%) โฌ‡๏ธ

Flags with carried forward coverage won't be shown. Click here to find out more.

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

@@ -12,6 +12,7 @@
import lombok.AccessLevel;
import lombok.Getter;
import lombok.NoArgsConstructor;
import lombok.Setter;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checkstyle์— ๊ฑธ๋ฆด ๊ฒƒ ๊ฐ™์•„์šฉ setter ์•ˆ ์“ฐ๋Š” ๊ฑฐ ๊ฐ™์€๋ฐ??

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๊ทธ๋ฆฌ๊ณ  ์ €ํฌ ์ด์ œ ๋ฐ”๋กœ dev์— ๋จธ์ง€ํ•˜๋‚˜์šฉ??

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

setter ์™œ checkstyle ์•ˆ๊ฑธ๋ ธ์„๊นŒ์š”,, ์ด์ œ dev๋ฐ”๋กœ ๋จธ์ง€ํ•ด๋„ ๋ ๊ฑฐ๊ฐ™์•„์„œ ๋นจ๋ฆฌ๋นจ๋ฆฌ ์ง„ํ–‰ํ•˜๋ ค๊ณ  dev์—๋‹ค๊ฐ€ ํ–ˆ์Šต๋‹ˆ๋‹น

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ํ˜น์‹œ ์–ด์ œ ๋ง์”€ํ•˜์…จ๋˜ ํ…Œ์ŠคํŠธ fail ์ด๋ถ€๋ถ„ ๊ณ ์น˜์‹  ๊ฑด๊ฐ€์š”??
์ €๋Š” application API 3๊ฐœ๊ฐ€ fail ๋–ด๊ฑฐ๋“ ์š”..ใ… ..ใ… 

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์˜ค ์™œ 3๊ฐœ์ง€,, ์ „ 2๊ฐœ ๊ณ„์† fail๋œจ๋Š”๊ฑฐ ์ด๊ฑฐ ๊ณ ์น˜๋‹ˆ๊นŒ ๋˜๊ธด ํ•˜๋”๋ผ๊ตฌ์š”

@wken5577 wken5577 merged commit 45e83f3 into dev Mar 29, 2024
2 checks passed
@wken5577 wken5577 deleted the 780-feature-recruit-status branch March 29, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

โœจ [Feature] ๋ชจ์ง‘๊ธ€ ์ƒํƒœ์ˆ˜์ • API
3 participants