-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT] recruit status change api #781
Conversation
Codecov ReportAll modified and coverable lines are covered by tests โ
Additional details and impacted files@@ Coverage Diff @@
## dev #781 +/- ##
============================================
+ Coverage 73.39% 74.97% +1.58%
- Complexity 1050 1075 +25
============================================
Files 363 363
Lines 4770 4772 +2
Branches 394 396 +2
============================================
+ Hits 3501 3578 +77
+ Misses 1095 1017 -78
- Partials 174 177 +3
Flags with carried forward coverage won't be shown. Click here to find out more. โ View full report in Codecov by Sentry. |
@@ -12,6 +12,7 @@ | |||
import lombok.AccessLevel; | |||
import lombok.Getter; | |||
import lombok.NoArgsConstructor; | |||
import lombok.Setter; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
checkstyle์ ๊ฑธ๋ฆด ๊ฒ ๊ฐ์์ฉ setter ์ ์ฐ๋ ๊ฑฐ ๊ฐ์๋ฐ??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
๊ทธ๋ฆฌ๊ณ ์ ํฌ ์ด์ ๋ฐ๋ก dev์ ๋จธ์งํ๋์ฉ??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
setter ์ checkstyle ์๊ฑธ๋ ธ์๊น์,, ์ด์ dev๋ฐ๋ก ๋จธ์งํด๋ ๋ ๊ฑฐ๊ฐ์์ ๋นจ๋ฆฌ๋นจ๋ฆฌ ์งํํ๋ ค๊ณ dev์๋ค๊ฐ ํ์ต๋๋น
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ํน์ ์ด์ ๋ง์ํ์
จ๋ ํ
์คํธ fail ์ด๋ถ๋ถ ๊ณ ์น์ ๊ฑด๊ฐ์??
์ ๋ application API 3๊ฐ๊ฐ fail ๋ด๊ฑฐ๋ ์..ใ
..ใ
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
์ค ์ 3๊ฐ์ง,, ์ 2๊ฐ ๊ณ์ fail๋จ๋๊ฑฐ ์ด๊ฑฐ ๊ณ ์น๋๊น ๋๊ธด ํ๋๋ผ๊ตฌ์
๐ ๊ฐ์
๐ป ์์ ์ฌํญ
โ ๋ณ๊ฒฝ๋ก์ง
๐กIssue ๋ฒํธ