Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

๐Ÿ› [Bug] [Refactoring] 6๊ธฐ Party ์„œ๋น„์Šค ์ „์ฒด ๋ฆฌํŒฉํ† ๋ง ์ค‘ ์ฐพ์€ ๋ฒ„๊ทธ๋“ค ์ˆ˜์ • #779

Merged
merged 4 commits into from
Mar 27, 2024

Conversation

AreSain
Copy link
Contributor

@AreSain AreSain commented Mar 27, 2024

๐Ÿ“Œ ๊ฐœ์š”

  • report๋œ comment ์กฐํšŒ๋˜๋˜ ๋ฒ„๊ทธ ์ˆ˜์ •
  • db์— ์—ฌ๋Ÿฌ๋ฒˆ ์ ‘๊ทผํ•˜๋˜ ์ฝ”๋“œ ์ˆ˜์ •
  • slack api ๋‹ค๋ฅธ res์ฐธ์กฐํ•˜๋˜ ๋ฒ„๊ทธ ์ˆ˜์ •

๐Ÿ’ป ์ž‘์—…์‚ฌํ•ญ

  • report๋œ comment ์กฐํšŒ๋˜๋˜ ๋ฒ„๊ทธ ์ˆ˜์ •
  • db์— ์—ฌ๋Ÿฌ๋ฒˆ ์ ‘๊ทผํ•˜๋˜ ์ฝ”๋“œ ์ˆ˜์ •
  • slack api ๋‹ค๋ฅธ res์ฐธ์กฐํ•˜๋˜ ๋ฒ„๊ทธ ์ˆ˜์ •
  • exception ์ˆœ์„œ ๋งž๊ฒŒ ์ˆ˜์ •
  • dto์— protect ์•ˆ๋˜์–ด์žˆ๋˜๊ฑฐ ์ˆ˜์ •
  • ๋กœ์ง๋“ค ๊ฐ„์†Œํ™”

๐Ÿ’กIssue ๋ฒˆํ˜ธ

@AreSain AreSain added the bug Something isn't working label Mar 27, 2024
@AreSain AreSain requested review from ghyen, yes-ee and JaBeast March 27, 2024 07:24
@AreSain AreSain self-assigned this Mar 27, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 74.83%. Comparing base (307954e) to head (5a70751).
Report is 14 commits behind head on dev.

Files Patch % Lines
...pi/user/noti/service/sns/SlackPartybotService.java 0.00% 6 Missing โš ๏ธ
Additional details and impacted files
@@             Coverage Diff              @@
##                dev     #779      +/-   ##
============================================
+ Coverage     73.39%   74.83%   +1.44%     
- Complexity     1050     1070      +20     
============================================
  Files           363      363              
  Lines          4770     4769       -1     
  Branches        394      394              
============================================
+ Hits           3501     3569      +68     
+ Misses         1095     1020      -75     
- Partials        174      180       +6     
Flag Coverage ฮ”
integrationTest 69.42% <0.00%> (+1.50%) โฌ†๏ธ
unitTest 32.20% <0.00%> (+<0.01%) โฌ†๏ธ

Flags with carried forward coverage won't be shown. Click here to find out more.

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

Copy link
Contributor

@wken5577 wken5577 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ghyen ghyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AreSain AreSain merged commit 7c2d9d0 into dev Mar 27, 2024
2 checks passed
@AreSain AreSain deleted the 778-refactoring-party-service branch March 27, 2024 07:45
@AreSain AreSain restored the 778-refactoring-party-service branch March 27, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants