Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

๐Ÿงช [Test] && ๐Ÿ› [Bug] ๋ฐฉ ์‹œ์ž‘ํ•˜๊ธฐ ๋ฐ ์ฐธ์—ฌํ•˜๊ธฐ์—์„œ ์‹œ์ž‘๋˜๋Š” ๋ถ€๋ถ„ ํ…Œ์ŠคํŠธ ์ฝ”๋“œ ์ž‘์„ฑ && ๋งˆ๊ฐ๋œ ๋ฐฉ && Finish๋ฐฉ Intra์กฐํšŒ #768

Conversation

AreSain
Copy link
Contributor

@AreSain AreSain commented Mar 25, 2024

๐Ÿ“Œ ๊ฐœ์š”

  • ๋ฐฉ ์‹œ์ž‘ํ•˜๊ธฐ ๋ฐ ์ฐธ์—ฌํ•˜๊ธฐ์— ์žˆ๋Š” ์‹œ์ž‘API ํ…Œ์ŠคํŠธ์ฝ”๋“œ ์ž‘์„ฑ

๐Ÿ’ป ์ž‘์—…์‚ฌํ•ญ

  • ๋ฐฉ ์‹œ์ž‘ํ•˜๊ธฐ ๋ฐ ์ฐธ์—ฌํ•˜๊ธฐ์— ์žˆ๋Š” ์‹œ์ž‘API ํ…Œ์ŠคํŠธ์ฝ”๋“œ ์ž‘์„ฑ
  • [Bug] ๋งˆ์ง€๋ง‰ ์‚ฌ๋žŒ์ด ๋‚˜๊ฐˆ๊ฒฝ์šฐ ๋ฐฉ์žฅ์ด๊ถŒ์ด ๋˜๋ ค์‹œ๋„ํ•˜๋‹ค Null ์ ‘๊ทผํ•˜๋Š” ๋ถ€๋ถ„ ์ˆ˜์ •
  • [Bug] FINISH๋œ ๋ฐฉ ์ฐธ์—ฌ์ž๊ฐ€ IntraId ๋ชป๋ณด๋Š” ๋ฒ„๊ทธ ์ˆ˜์ •
  • [Bug] ์Šค์ผ€์ค„๋Ÿฌ๊ฐ€ ์‹œ๊ฐ„์— ์ƒ๊ด€์—†์ด START๋œ ๋ฐฉ์„ FINISH๋กœ ๋งŒ๋“ค๋˜ ๋ฒ„๊ทธ ์ˆ˜์ •
  • ๋ฐฉ ์ƒ์„ธ์กฐํšŒ ํ…Œ์ŠคํŠธ์ผ€์ด์Šค ๋ฐ RoomControllerTest ์ฝ”๋“œ ๋ฆฌํŒฉํ† ๋ง(๋ฐ˜๋ณต๋ฌธ์œผ๋กœ ์ˆ˜์ •)
  • ๋ฐฉ ์‹œ์ž‘ํ•˜๊ธฐ ์—๋Ÿฌ์ฝ”๋“œ ๋‹ค๋ฅธ ๊ฒƒ ๋“ค ์ˆ˜์ •
  • [Feature] ๋ฐฉ 10๊ฐœ๊นŒ์ง€ ์กฐํšŒํ•˜๊ฒŒ ์ˆ˜์ •

๐Ÿ’กIssue ๋ฒˆํ˜ธ

@AreSain AreSain added bug Something isn't working refactoring test labels Mar 25, 2024
@AreSain AreSain requested review from ghyen, yes-ee and JaBeast March 25, 2024 07:28
@AreSain AreSain self-assigned this Mar 25, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests โœ…

Project coverage is 32.20%. Comparing base (307954e) to head (3bd9215).
Report is 5 commits behind head on dev.

Additional details and impacted files
@@              Coverage Diff              @@
##                dev     #768       +/-   ##
=============================================
- Coverage     73.39%   32.20%   -41.19%     
+ Complexity     1050      427      -623     
=============================================
  Files           363      363               
  Lines          4770     4769        -1     
  Branches        394      394               
=============================================
- Hits           3501     1536     -1965     
- Misses         1095     3203     +2108     
+ Partials        174       30      -144     
Flag Coverage ฮ”
integrationTest ?
unitTest 32.20% <รธ> (+<0.01%) โฌ†๏ธ

Flags with carried forward coverage won't be shown. Click here to find out more.

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

Copy link
Contributor

@JaBeast JaBeast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gg

@ghyen ghyen merged commit e3f3193 into dev Mar 25, 2024
2 checks passed
@ghyen ghyen deleted the 766-test-๋ฐฉ-์‹œ์ž‘-ํ…Œ์ŠคํŠธ์ฝ”๋“œ branch March 25, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment