Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

๐Ÿงช [Test] ํŒจ๋„ํ‹ฐ ๊ด€๋ จ ํ…Œ์ŠคํŠธ ์ฝ”๋“œ ์ž‘์„ฑ #767

Conversation

JaBeast
Copy link
Contributor

@JaBeast JaBeast commented Mar 25, 2024

๐Ÿ“Œ ๊ฐœ์š”

  • ํŒจ๋„ํ‹ฐ ์กฐํšŒ, ์ˆ˜์ •, ์ถ”๊ฐ€/๋ถ€์—ฌ ํ…Œ์ŠคํŠธ ์ฝ”๋“œ ์ž‘์„ฑ

๐Ÿ’ป ์ž‘์—…์‚ฌํ•ญ

  • PartyPenaltyControllerTest ์ฝ”๋“œ ์ถ”๊ฐ€
  • Controller์— valid๋กœ null ๋ฐฉ์ง€

๐Ÿ’กIssue ๋ฒˆํ˜ธ

@JaBeast JaBeast added the test label Mar 25, 2024
@JaBeast JaBeast requested review from ghyen, yes-ee and AreSain March 25, 2024 04:33
@JaBeast JaBeast self-assigned this Mar 25, 2024
@JaBeast JaBeast changed the title [feature] ํŒจ๋„ํ‹ฐ ๊ด€๋ จ ํ…Œ์ŠคํŠธ ์ฝ”๋“œ ์ž‘์„ฑ [test] ํŒจ๋„ํ‹ฐ ๊ด€๋ จ ํ…Œ์ŠคํŠธ ์ฝ”๋“œ ์ž‘์„ฑ Mar 25, 2024
@JaBeast JaBeast changed the title [test] ํŒจ๋„ํ‹ฐ ๊ด€๋ จ ํ…Œ์ŠคํŠธ ์ฝ”๋“œ ์ž‘์„ฑ ๐Ÿงช [Test] ํŒจ๋„ํ‹ฐ ๊ด€๋ จ ํ…Œ์ŠคํŠธ ์ฝ”๋“œ ์ž‘์„ฑ Mar 25, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests โœ…

Project coverage is 74.98%. Comparing base (307954e) to head (9abe011).
Report is 9 commits behind head on dev.

โ— Current head 9abe011 differs from pull request most recent head 21690fd. Consider uploading reports for the commit 21690fd to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##                dev     #767      +/-   ##
============================================
+ Coverage     73.39%   74.98%   +1.58%     
- Complexity     1050     1074      +24     
============================================
  Files           363      363              
  Lines          4770     4769       -1     
  Branches        394      394              
============================================
+ Hits           3501     3576      +75     
+ Misses         1095     1018      -77     
- Partials        174      175       +1     
Flag Coverage ฮ”
integrationTest 69.51% <รธ> (+1.58%) โฌ†๏ธ
unitTest 32.20% <รธ> (+<0.01%) โฌ†๏ธ

Flags with carried forward coverage won't be shown. Click here to find out more.

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

@JaBeast JaBeast requested a review from AreSain March 26, 2024 05:25
AreSain
AreSain previously approved these changes Mar 26, 2024
Copy link
Contributor

@AreSain AreSain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๊ณ ์ƒํ•˜์…จ์Šต๋‹ˆ๋‹ค.

@AreSain AreSain self-requested a review March 26, 2024 08:18
Copy link
Contributor

@AreSain AreSain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๊ณ ์ƒํ•˜์…จ์Šต๋‹ˆ๋‹ค.

@AreSain AreSain merged commit 980f1f6 into dev Mar 26, 2024
2 checks passed
@AreSain AreSain deleted the 765-ํŒจ๋„ํ‹ฐ-์กฐํšŒ,์ถ”๊ฐ€,์ˆ˜์ •-ํ…Œ์ŠคํŠธ์ฝ”๋“œ branch March 26, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants