Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

๐Ÿงช [Test] Admin ๋ฐฉ ๋ชฉ๋ก ์กฐํšŒ ๋ฐ ๋ฐฉ ์ƒ์„ธ ์กฐํšŒ ๋ฐ ๋ฐฉ Status๋ณ€๊ฒฝ ํ…Œ์ŠคํŠธ์ฝ”๋“œ ์ž‘์„ฑ #762

Conversation

AreSain
Copy link
Contributor

@AreSain AreSain commented Mar 24, 2024

๐Ÿ“Œ ๊ฐœ์š”

  • admin ๋ฐฉ ๋ชฉ๋ก ์กฐํšŒ ๋ฐ ๋ฐฉ ์ƒ์„ธ์กฐํšŒ ๋ฐ ๋ฐฉ status๋ณ€๊ฒฝํ•˜๋Š” ํ…Œ์ŠคํŠธ์ฝ”๋“œ๋ฅผ ์ž‘์„ฑํ–ˆ์Šต๋‹ˆ๋‹ค.

๐Ÿ’ป ์ž‘์—…์‚ฌํ•ญ

  • ๋ฐฉ์— ์•„๋ฌด๋„ ์—†๋Š” ๊ฒฝ์šฐ ์กฐํšŒ๊ฐ€ ์•ˆ๋˜๋˜ ๋กœ์ง์„ ์ˆ˜์ •ํ–ˆ์Šต๋‹ˆ๋‹ค..
  • admin ๋ฐฉ ๋ชฉ๋ก ์กฐํšŒ ๋ฐ ๋ฐฉ ์ƒ์„ธ์กฐํšŒ ๋ฐ ๋ฐฉ status๋ณ€๊ฒฝํ•˜๋Š” ํ…Œ์ŠคํŠธ์ฝ”๋“œ๋ฅผ ์ž‘์„ฑํ–ˆ์Šต๋‹ˆ๋‹ค.

๐Ÿ’กIssue ๋ฒˆํ˜ธ

@AreSain AreSain requested review from ghyen, yes-ee and JaBeast March 24, 2024 14:51
@AreSain AreSain self-assigned this Mar 24, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 24, 2024

Codecov Report

All modified and coverable lines are covered by tests โœ…

Project coverage is 73.56%. Comparing base (307954e) to head (662d336).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev     #762      +/-   ##
============================================
+ Coverage     73.39%   73.56%   +0.16%     
- Complexity     1050     1055       +5     
============================================
  Files           363      363              
  Lines          4770     4770              
  Branches        394      394              
============================================
+ Hits           3501     3509       +8     
+ Misses         1095     1080      -15     
- Partials        174      181       +7     
Flag Coverage ฮ”
integrationTest 68.09% <รธ> (+0.16%) โฌ†๏ธ
unitTest 32.20% <รธ> (รธ)

Flags with carried forward coverage won't be shown. Click here to find out more.

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

@AreSain AreSain added the test label Mar 25, 2024
JaBeast
JaBeast previously approved these changes Mar 25, 2024
Copy link
Contributor

@JaBeast JaBeast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gg

Copy link
Contributor

@ghyen ghyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@JaBeast JaBeast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gg

@AreSain AreSain merged commit a31080c into dev Mar 25, 2024
2 checks passed
@AreSain AreSain deleted the 761-test-admin-๋ฐฉ-์กฐํšŒ-์ƒ์„ธ์กฐํšŒ-status๋ณ€๊ฒฝ branch March 25, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants