Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

647 노쇼 신고 api #723

Merged
merged 6 commits into from
Mar 19, 2024
Merged

647 노쇼 신고 api #723

merged 6 commits into from
Mar 19, 2024

Conversation

ghyen
Copy link
Contributor

@ghyen ghyen commented Mar 11, 2024

📌 개요

  • 노쇼 신고 API

✅ 변경로직

  • UserNotInRoom exception 클래스의 부모 클래스를 Runtimeexception 에서 Duplicateexception으로 변경

💡Issue 번호

@ghyen ghyen self-assigned this Mar 11, 2024
@ghyen ghyen requested review from JaBeast, AreSain and yes-ee March 11, 2024 11:50
@ghyen ghyen added the enhancement New feature or request label Mar 11, 2024
@ghyen ghyen requested review from yes-ee and AYoungSn March 12, 2024 12:04
@codecov-commenter
Copy link

codecov-commenter commented Mar 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 72.00%. Comparing base (e9225ee) to head (91b898f).
Report is 30 commits behind head on dev.

Files Patch % Lines
...g-data/src/main/java/gg/data/party/UserReport.java 0.00% 6 Missing ⚠️
...va/gg/utils/exception/party/UserAlreadyInRoom.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev     #723      +/-   ##
============================================
- Coverage     74.16%   72.00%   -2.17%     
- Complexity      737     1009     +272     
============================================
  Files           166      350     +184     
  Lines          3178     4672    +1494     
  Branches        340      394      +54     
============================================
+ Hits           2357     3364    +1007     
- Misses          677     1131     +454     
- Partials        144      177      +33     
Flag Coverage Δ
integrationTest 66.41% <0.00%> (-1.87%) ⬇️
unitTest 32.81% <0.00%> (+3.61%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

yes-ee
yes-ee previously approved these changes Mar 13, 2024
Copy link
Contributor

@yes-ee yes-ee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다
이제 테스트코드를 작성해봅시다

AreSain
AreSain previously approved these changes Mar 13, 2024
Copy link
Contributor

@AreSain AreSain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다.

JaBeast
JaBeast previously approved these changes Mar 14, 2024
Copy link
Contributor

@JaBeast JaBeast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gg 수고하셨습니다

@AreSain AreSain dismissed stale reviews from JaBeast, yes-ee, and themself via 235966f March 18, 2024 05:11
@AreSain AreSain requested review from AreSain and JaBeast March 19, 2024 01:33
@JaBeast JaBeast merged commit fc3bd55 into dev Mar 19, 2024
2 checks passed
@AreSain AreSain deleted the 647-노쇼-신고-API branch March 19, 2024 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ [Feature] 노쇼 신고 API
6 participants