Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [Feature] admin 댓글,방,노쇼 신고조회 api #719

Merged
merged 14 commits into from
Mar 13, 2024

Conversation

JaBeast
Copy link
Contributor

@JaBeast JaBeast commented Mar 11, 2024

📌 개요

  • Admin 댓글, 방, 노쇼 신고 조회 api

💻 작업사항

  • Admin report에 CommentReportList dto 추가
  • Admin report에 RoomReportList dto 추가
  • Admin report에 UserReportList dto 추가
  • Admin report에 Controller 추가
  • Admin report에 �Service 추가
  • CommentReport, UserReport repository 추가
  • 페이징 기능 추가
  • fetch join 추가

💡Issue 번호

@JaBeast JaBeast requested review from ghyen, yes-ee and AreSain March 11, 2024 08:05
@JaBeast JaBeast self-assigned this Mar 11, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.75%. Comparing base (e9225ee) to head (a9f6b93).
Report is 26 commits behind head on dev.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev     #719      +/-   ##
============================================
- Coverage     74.16%   72.75%   -1.41%     
- Complexity      737     1006     +269     
============================================
  Files           166      344     +178     
  Lines          3178     4614    +1436     
  Branches        340      394      +54     
============================================
+ Hits           2357     3357    +1000     
- Misses          677     1080     +403     
- Partials        144      177      +33     
Flag Coverage Δ
integrationTest 67.12% <ø> (-1.17%) ⬇️
unitTest 33.18% <ø> (+3.98%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ghyen
ghyen previously approved these changes Mar 11, 2024
@JaBeast JaBeast requested review from ghyen and AYoungSn March 12, 2024 04:26
@JaBeast JaBeast closed this Mar 12, 2024
ghyen
ghyen previously approved these changes Mar 12, 2024
@JaBeast JaBeast reopened this Mar 12, 2024
@JaBeast JaBeast requested a review from ghyen March 12, 2024 06:09
+ "JOIN FETCH cr.reporter "
+ "JOIN FETCH cr.comment "
+ "JOIN FETCH cr.room",
countQuery = "SELECT count(cr) FROM CommentReport cr")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

count query 는 필요 없을것 같은데 추가하신 이유가 있나요?

Copy link
Contributor Author

@JaBeast JaBeast Mar 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pageable과 fetch join같이 쓰면 에러 뜹니다(같이 사용 불가). 그래서 query를 fetch join하는데 유효하게 만들기 위해서 사용했습니다.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이때 join 이 내부적으로 inner join 으로 실행되는 것으로 아는데, join 후와 join 전 쿼리 수가 달라지는 경우는 없나요?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fetch 하는것 중에서 입력값이 없으면(예를 들어서 comment) 안가져올 것 같은데 이런거는 안가져오는게 맞을것 같습니다.

@JaBeast JaBeast merged commit 1b7d451 into dev Mar 13, 2024
2 checks passed
@JaBeast JaBeast deleted the 718-feature-admin-댓글,방,노쇼-신고조회 branch March 13, 2024 12:46
@JaBeast JaBeast restored the 718-feature-admin-댓글,방,노쇼-신고조회 branch March 13, 2024 12:46
@JaBeast JaBeast deleted the 718-feature-admin-댓글,방,노쇼-신고조회 branch March 15, 2024 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ [Feature] Admin 댓글, 방, 노쇼 신고 리스트 조회 API
5 participants