-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ [Feature] admin 댓글,방,노쇼 신고조회 api #719
The head ref may contain hidden characters: "718-feature-admin-\uB313\uAE00,\uBC29,\uB178\uC1FC-\uC2E0\uACE0\uC870\uD68C"
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #719 +/- ##
============================================
- Coverage 74.16% 72.75% -1.41%
- Complexity 737 1006 +269
============================================
Files 166 344 +178
Lines 3178 4614 +1436
Branches 340 394 +54
============================================
+ Hits 2357 3357 +1000
- Misses 677 1080 +403
- Partials 144 177 +33
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
gg-pingpong-api/src/main/java/gg/party/api/admin/report/service/ReportAdminService.java
Outdated
Show resolved
Hide resolved
...rc/main/java/gg/party/api/admin/report/controller/response/CommentReportListAdminResDto.java
Outdated
Show resolved
Hide resolved
+ "JOIN FETCH cr.reporter " | ||
+ "JOIN FETCH cr.comment " | ||
+ "JOIN FETCH cr.room", | ||
countQuery = "SELECT count(cr) FROM CommentReport cr") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
count query 는 필요 없을것 같은데 추가하신 이유가 있나요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pageable과 fetch join같이 쓰면 에러 뜹니다(같이 사용 불가). 그래서 query를 fetch join하는데 유효하게 만들기 위해서 사용했습니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이때 join 이 내부적으로 inner join 으로 실행되는 것으로 아는데, join 후와 join 전 쿼리 수가 달라지는 경우는 없나요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fetch 하는것 중에서 입력값이 없으면(예를 들어서 comment) 안가져올 것 같은데 이런거는 안가져오는게 맞을것 같습니다.
📌 개요
💻 작업사항
💡Issue 번호