Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] 카테고리 추가 API #705

Merged
merged 11 commits into from
Mar 8, 2024
Merged

Conversation

yes-ee
Copy link
Contributor

@yes-ee yes-ee commented Mar 7, 2024

📌 개요

  • admin에서 카테고리를 추가하는 api

💻 작업사항

  • admin 권한으로 카테고리 추가 가능
  • 카테고리명이 중복된 경우 에러

💡Issue 번호

@yes-ee yes-ee requested review from ghyen, JaBeast and AreSain March 7, 2024 11:31
@yes-ee yes-ee self-assigned this Mar 7, 2024
@yes-ee yes-ee added the enhancement New feature or request label Mar 7, 2024
ghyen
ghyen previously approved these changes Mar 7, 2024
Copy link
Contributor

@ghyen ghyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Mar 8, 2024

Codecov Report

Attention: Patch coverage is 16.66667% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 73.74%. Comparing base (e9225ee) to head (16088f4).
Report is 17 commits behind head on dev.

Files Patch % Lines
gg-data/src/main/java/gg/data/party/Category.java 0.00% 3 Missing ⚠️
...ls/exception/party/CategoryDuplicateException.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev     #705      +/-   ##
============================================
- Coverage     74.16%   73.74%   -0.43%     
- Complexity      737      998     +261     
============================================
  Files           166      335     +169     
  Lines          3178     4525    +1347     
  Branches        340      390      +50     
============================================
+ Hits           2357     3337     +980     
- Misses          677     1015     +338     
- Partials        144      173      +29     
Flag Coverage Δ
integrationTest 68.15% <16.66%> (-0.13%) ⬇️
unitTest 33.41% <16.66%> (+4.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yes-ee yes-ee merged commit 0900834 into dev Mar 8, 2024
2 checks passed
@yes-ee yes-ee deleted the 653-feature-admin-category-add branch March 12, 2024 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ [Feature] Admin 카테고리 추가 API
4 participants