Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] #688 api module add #689

Merged
merged 3 commits into from
Mar 6, 2024
Merged

Conversation

wken5577
Copy link
Contributor

@wken5577 wken5577 commented Mar 6, 2024

๐Ÿ“Œ ๊ฐœ์š”

  • api module ์ถ”๊ฐ€ํ–ˆ์Šต๋‹ˆ๋‹ค

๐Ÿ’ป ์ž‘์—…์‚ฌํ•ญ

  • pingpong-api์—์„œ recruit-api ์˜์กดํ•˜๋Š” ์ด์œ ๋Š” component scan๊ด€๋ จํ•ด์„œ ๋“ฑ๋กํ•ด์•ผํ•˜๊ธฐ ๋•Œ๋ฌธ์— ์ถ”๊ฐ€ํ–ˆ์Šต๋‹ˆ๋‹ค
  • devtools๋Š” ์‚ฌ์šฉํ•˜๋ฉด ํŽธํ•œ๊ฑฐ๊ฐ™์•„์„œ ์ถ”๊ฐ€ํ–ˆ์Šต๋‹ˆ๋‹ค
  • testcontroller๋กœ ์ž˜ ๋™์ž‘ํ•˜๋Š”๊ฑฐ ํ™•์ธํ–ˆ๊ณ  dir์—…๋กœ๋“œ๋ฅผ ์œ„ํ•ด ์ง€์šฐ์ง€์•Š๊ณ  ์˜ฌ๋ฆฝ๋‹ˆ๋‹ค

โœ… ๋ณ€๊ฒฝ๋กœ์ง

๐Ÿ’กIssue ๋ฒˆํ˜ธ

@wken5577 wken5577 added the enhancement New feature or request label Mar 6, 2024
@wken5577 wken5577 self-assigned this Mar 6, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests โœ…

โ— No coverage uploaded for pull request base (recruit-dev@808391d). Click here to learn what that means.

Additional details and impacted files
@@              Coverage Diff               @@
##             recruit-dev     #689   +/-   ##
==============================================
  Coverage               ?   74.22%           
  Complexity             ?      733           
==============================================
  Files                  ?      164           
  Lines                  ?     3162           
  Branches               ?      337           
==============================================
  Hits                   ?     2347           
  Misses                 ?      674           
  Partials               ?      141           
Flag Coverage ฮ”
integrationTest 68.34% <รธ> (?)
unitTest 29.34% <รธ> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

Copy link
Contributor

@AYoungSn AYoungSn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

implementation json web token ํ•„์š”ํ•œ๊ฐ€์—ฌ?? auth ๋ชจ๋“ˆ์—๋งŒ ์žˆ์œผ๋ฉด ๋˜๋Š”๊ฒŒ ์•„๋‹Œ๊ฐ€์š”??

@wken5577
Copy link
Contributor Author

wken5577 commented Mar 6, 2024

implementation json web token ํ•„์š”ํ•œ๊ฐ€์—ฌ?? auth ๋ชจ๋“ˆ์—๋งŒ ์žˆ์œผ๋ฉด ๋˜๋Š”๊ฒŒ ์•„๋‹Œ๊ฐ€์š”??

๋„ค ๋งž๋Š” ๊ฒƒ ๊ฐ™์•„์š”

@wken5577 wken5577 requested a review from AYoungSn March 6, 2024 10:23
Copy link
Contributor

@AYoungSn AYoungSn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

build.gradle Show resolved Hide resolved
@wken5577 wken5577 merged commit a25c077 into recruit-dev Mar 6, 2024
2 checks passed
@Kimhan-nah Kimhan-nah deleted the 688-feature-recruit-api-module branch April 5, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants