Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

πŸ’š [chore] codecov, jacoco λͺ¨λ“ˆμ— 맞게 λ³€κ²½ #683

Merged
merged 1 commit into from
Mar 7, 2024
Merged

πŸ’š [chore] codecov, jacoco λͺ¨λ“ˆμ— 맞게 λ³€κ²½ #683

merged 1 commit into from
Mar 7, 2024

Conversation

middlefitting
Copy link
Member

@middlefitting middlefitting commented Mar 5, 2024 •
edited
Loading

πŸ“Œ κ°œμš”

  • jacoco, codecov λ₯Ό ν˜„μž¬ λͺ¨λ“ˆμ— 맞게 μ‹œκ°ν™”ν•©λ‹ˆλ‹€

πŸ’‘Issue 번호

@middlefitting middlefitting linked an issue Mar 5, 2024 that may be closed by this pull request
πŸ›Β [Bug] jacoco, codev 수리 #682
Closed
@middlefitting middlefitting marked this pull request as draft March 5, 2024 08:21
@codecov-commenter
Copy link

codecov-commenter commented Mar 5, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 73.93%. Comparing base (e9225ee) to head (a9f1ad8).
Report is 9 commits behind head on dev.

Additional details and impacted files 
@@             Coverage Diff              @@
##                dev     #683      +/-   ##
============================================
- Coverage     74.16%   73.93%   -0.23%     
- Complexity      737      995     +258     
============================================
  Files           166      329     +163     
  Lines          3178     4501    +1323     
  Branches        340      390      +50     
============================================
+ Hits           2357     3328     +971     
- Misses          677      996     +319     
- Partials        144      177      +33
Flag Coverage Ξ”
integrationTest 68.27% <ΓΈ> (-0.01%) ⬇️
unitTest 33.50% <ΓΈ> (+4.30%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@middlefitting middlefitting force-pushed the 682-bug-jacoco-codev-수리 branch 6 times, most recently from 3ceae8f to af2f589 Compare March 5, 2024 11:43
@middlefitting middlefitting changed the title fix: codecov πŸ’š chore: codecov, jacoco λͺ¨λ“ˆμ— 맞게 λ³€κ²½ Mar 5, 2024
@middlefitting middlefitting changed the title πŸ’š chore: codecov, jacoco λͺ¨λ“ˆμ— 맞게 λ³€κ²½ πŸ’š [chore] codecov, jacoco λͺ¨λ“ˆμ— 맞게 λ³€κ²½ Mar 5, 2024
@middlefitting middlefitting self-assigned this Mar 5, 2024
@middlefitting middlefitting added the bug Something isn't working label Mar 5, 2024
@middlefitting middlefitting marked this pull request as ready for review March 5, 2024 12:09
Kimhan-nah
Kimhan-nah previously approved these changes Mar 5, 2024
View reviewed changes
Copy link
Member

@Kimhan-nah Kimhan-nah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

κ°μ‚¬ν•©λ‹ˆλ‹€ γ…Ž.γ…Ž

wken5577
wken5577 previously approved these changes Mar 6, 2024
View reviewed changes
Copy link
Contributor

@wken5577 wken5577 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ν™•μΈμ™„λ£Œ

@middlefitting middlefitting dismissed stale reviews from wken5577 and Kimhan-nah via a9f1ad8 March 7, 2024 03:48
@middlefitting middlefitting force-pushed the 682-bug-jacoco-codev-수리 branch from af2f589 to a9f1ad8 Compare March 7, 2024 03:48
@middlefitting middlefitting merged commit 21dacea into dev Mar 7, 2024
2 checks passed
@middlefitting middlefitting deleted the 682-bug-jacoco-codev-수리 branch March 7, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AYoungSn AYoungSn AYoungSn approved these changes

@Kimhan-nah Kimhan-nah Kimhan-nah approved these changes

@wken5577 wken5577 wken5577 left review comments

Assignees

@middlefitting middlefitting

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

πŸ›Β [Bug] jacoco, codev 수리
5 participants
@middlefitting @codecov-commenter @Kimhan-nah @AYoungSn @wken5577