Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] 댓글 생성 api #669

Merged
merged 4 commits into from
Mar 3, 2024
Merged

[Feature] 댓글 생성 api #669

merged 4 commits into from
Mar 3, 2024

Conversation

yes-ee
Copy link
Contributor

@yes-ee yes-ee commented Mar 2, 2024

📌 개요

  • 게시글에 댓글 작성하는 API 생성

💻 작업사항

  • due date를 넘지 않은 방에만 댓글 작성 가능
  • 현재 참여 중인 방에만 댓글 작성 가능

💡Issue 번호

@yes-ee yes-ee added the enhancement New feature or request label Mar 2, 2024
@yes-ee yes-ee requested review from ghyen, JaBeast and AreSain March 2, 2024 14:29
@yes-ee yes-ee self-assigned this Mar 2, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.16%. Comparing base (3193717) to head (e9225ee).
Report is 38 commits behind head on dev.

Additional details and impacted files
@@              Coverage Diff              @@
##                dev     #669       +/-   ##
=============================================
+ Coverage     10.25%   74.16%   +63.90%     
- Complexity       78      737      +659     
=============================================
  Files           255      166       -89     
  Lines          3812     3178      -634     
  Branches        357      340       -17     
=============================================
+ Hits            391     2357     +1966     
+ Misses         3410      677     -2733     
- Partials         11      144      +133     
Flag Coverage Δ
integrationTest 68.28% <ø> (?)
unitTest 29.20% <ø> (+18.94%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

AreSain
AreSain previously approved these changes Mar 3, 2024
Copy link
Contributor

@AreSain AreSain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다. 차후 에러코드는 refactoring으로 진행하시죠

@ghyen ghyen self-requested a review March 3, 2024 15:53
ghyen
ghyen previously approved these changes Mar 3, 2024
Copy link
Contributor

@ghyen ghyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 컨플릭트 리졸브만 해주세요

@yes-ee yes-ee requested review from AreSain and ghyen March 3, 2024 16:56
Copy link
Contributor

@ghyen ghyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yes-ee yes-ee merged commit d2f2401 into dev Mar 3, 2024
2 checks passed
@yes-ee yes-ee deleted the 642-feature-comment branch March 3, 2024 17:24
Copy link
Member

@Kimhan-nah Kimhan-nah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인 부탁드립니다!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ [Feature] 댓글 작성 API
5 participants