Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] table 초기화 flyway 작성 및 방 전체 조회 api #666

Merged
merged 12 commits into from
Mar 1, 2024
Merged

[Feature] table 초기화 flyway 작성 및 방 전체 조회 api #666

merged 12 commits into from
Mar 1, 2024

Conversation

AreSain
Copy link
Contributor

@AreSain AreSain commented Mar 1, 2024 •
edited by yes-ee
Loading

📌 개요

  • 폴더 구조 작성
  • 방 전체목록을 sort해서 GET하는 전체 조회입니다.

💻 작업사항

  • 폴더 구조 작성
    • flyway table 초기화 sql 작성
    • 엔티티 작성
    • 방 전체 조회하는 api 작성

💡Issue 번호

@codecov-commenter
Copy link

codecov-commenter commented Mar 1, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.20%. Comparing base (da7fe73) to head (3babc52).

Additional details and impacted files 
@@              Coverage Diff              @@
##                dev     #666       +/-   ##
=============================================
- Coverage     74.12%   29.20%   -44.93%     
+ Complexity      738      290      -448     
=============================================
  Files           167      166        -1     
  Lines          3181     3178        -3     
  Branches        340      340               
=============================================
- Hits           2358      928     -1430     
- Misses          679     2221     +1542     
+ Partials        144       29      -115
Flag Coverage Δ
integrationTest ?
unitTest 29.20% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Kimhan-nah Kimhan-nah added the enhancement New feature or request label Mar 1, 2024
ghyen
ghyen approved these changes Mar 1, 2024
View reviewed changes
Copy link
Contributor

@ghyen ghyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

yes-ee
yes-ee approved these changes Mar 1, 2024
View reviewed changes
Copy link
Contributor

@yes-ee yes-ee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@AreSain AreSain merged commit bea0ad9 into dev Mar 1, 2024
2 checks passed
@AreSain AreSain deleted the 6th-dev branch March 1, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yes-ee yes-ee yes-ee approved these changes

@ghyen ghyen ghyen approved these changes

@Kimhan-nah Kimhan-nah Awaiting requested review from Kimhan-nah

@JaBeast JaBeast Awaiting requested review from JaBeast

Assignees

@ghyen ghyen

@yes-ee yes-ee

@JaBeast JaBeast

@AreSain AreSain

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

✨ [Feature] 방 목록 전체 조회 API ✨[Feature] 엔티티 생성 및 폴더 구조 생성
6 participants
@AreSain @codecov-commenter @Kimhan-nah @ghyen @yes-ee @JaBeast