Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ§ͺ [Unit Test] Game unit test #628

Merged
merged 10 commits into from
Apr 3, 2024
Merged

πŸ§ͺ [Unit Test] Game unit test #628

merged 10 commits into from
Apr 3, 2024

Conversation

SONGS4RI
Copy link
Contributor

@SONGS4RI SONGS4RI commented Feb 25, 2024

πŸ“Œ κ°œμš”

-Game unit test 쀑 일뢀 μœ λ‹› ν…ŒμŠ€νŠΈ pr μž…λ‹ˆλ‹€.

πŸ’» μž‘μ—…μ‚¬ν•­

  • GameFindService::allGameListUser 동적 ν• λ‹Ή λΆ€λΆ„ μΆ”κ°€
    • Arrays.asList(StatusType.END.name()) λŠ” 동적 할당이 μ•„λ‹ˆμ–΄μ„œ add ν•˜λ©΄ μ—λŸ¬ λ°œμƒ
  • GameFindService μœ λ‹› ν…ŒμŠ€νŠΈ
  • PChangeService μœ λ‹› ν…ŒμŠ€νŠΈ
  • GameStatusServiceUnitTest μΆ”κ°€
  • GameStatusService javadoc μΆ”κ°€

βœ… λ³€κ²½λ‘œμ§

πŸ’‘Issue 번호

@SONGS4RI SONGS4RI added the test label Feb 25, 2024
@SONGS4RI SONGS4RI self-assigned this Feb 25, 2024
@codecov-commenter
Copy link

codecov-commenter commented Feb 25, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 75.46%. Comparing base (6c42a3d) to head (c5d6b86).

Files Patch % Lines
...gg/pingpong/api/user/game/service/GameService.java 90.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev     #628      +/-   ##
============================================
+ Coverage     75.06%   75.46%   +0.39%     
- Complexity     1073     1078       +5     
============================================
  Files           363      363              
  Lines          4764     4764              
  Branches        393      393              
============================================
+ Hits           3576     3595      +19     
+ Misses         1014      993      -21     
- Partials        174      176       +2     
Flag Coverage Ξ”
integrationTest 69.58% <75.00%> (-0.03%) ⬇️
unitTest 34.99% <75.00%> (+2.74%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

Copy link
Contributor

@Newsujin Newsujin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

κ³ μƒν•˜μ…¨μŠ΅λ‹ˆλ‹€!!

@SONGS4RI SONGS4RI merged commit 01bec09 into dev Apr 3, 2024
2 checks passed
@SONGS4RI SONGS4RI deleted the game-unit-test branch April 3, 2024 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants